Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linux): Build with webkitgtk 4.1 instead of 4.0 #10483

Merged
merged 4 commits into from Jan 29, 2024
Merged

chore(linux): Build with webkitgtk 4.1 instead of 4.0 #10483

merged 4 commits into from Jan 29, 2024

Conversation

jbicha
Copy link
Contributor

@jbicha jbicha commented Jan 23, 2024

webkitgtk 4.1 is the same API as 4.0 except that it uses libsoup3 instead of libsoup 2.4.

Fedora has stopped building the 4.0 API (in preparation for Fedora 40 in a few months). Debian and Ubuntu will also stop building the 4.0 API soon.

webkitgtk 4.1 should exist in currently mainatained distros. It is in Debian 12, Ubuntu 22.04 LTS, etc.

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jan 23, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 23, 2024 •
edited

User Test Results

Test specification and instructions

  • ✅ GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

    2 tests PASSED
    • ✅ TEST_KB_INSTALL (PASSED): Tested this as per the instructions in Ubuntu 20.04 Focal with Gnome Shell and X11 and here is my observation: 1. Downloaded then installed the PR build (Keyman 17.0.251-alpha-local (package version 17.0.251-1~PR-10483-2137.1+focal1) from Debian Packaging Artifacts Site. 2. Downloaded and installed the "IPA (SIL) keyboard 2. Verified that the Readme was shown in the "README" tab of the install window during the installation. 3. Verified that the Welcome page appeared after the installation. 4. Verified that the "Keyman Configuration" appeared on the screen. (notes)
    • ✅ TEST_KB_OPTIONS (PASSED): 1. Verified that the Options dialog appeared after clicking the "Options" button from Keyman Configuration window. (notes)

  • ✅ GROUP_MANTIC_X11: Ubuntu 23.10 Mantic with Gnome Shell and X11

    2 tests PASSED
    • ✅ TEST_KB_INSTALL (PASSED): Tested this as per the instructions in Ubuntu 23.10 Manitc with Gnome Shell and X11 and here is my observation: 1. Downloaded then installed the PR build (Keyman 17.0.251-alpha-local (package version 17.0.251-1~PR-10483-2137.1+mantic1) from Debian Packaging Artifacts Site. 2. Downloaded and installed the "IPA (SIL) keyboard 2. Verified that the Readme was shown in the "README" tab of the install window during the installation. 3. Verified that the Welcome page appeared after the installation. 4. Verified that the "Keyman Configuration" appeared on the screen.
    • ✅ TEST_KB_OPTIONS (PASSED): 1. Verified that the Options dialog appeared after clicking the "Options" button from Keyman Configuration window. (notes)

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S31 milestone Jan 23, 2024
@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@mcdurdin
Copy link
Member

Thanks for your PR! @ermshiperete will review it soon.

@ermshiperete
chore(core): Update debian package to use webkit2 4.1
29c7125 
Ubuntu 20.04 Focal doesn't have webkit2 4.1. The API is the same as
with 4.0, so we use that if we can't find 4.1.
@ermshiperete
chore(linux): Update changelog
052ac3e
@ermshiperete
chore(linux): Fix changelog
e33d5ef 
Should be a new version...
@ermshiperete
Copy link
Contributor

User Testing

Preparations

  • The tests should be run on these Linux platforms:

    • GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11
    • GROUP_MANTIC_X11: Ubuntu 23.10 Mantic with Gnome Shell and X11

  • Install build artifacts of this PR

  • Reboot

Tests

  • TEST_KB_INSTALL: Download and install a keyboard
    • Click "Download", enter search for "IPA", and click the "IPA (SIL)" keyboard
    • Click "Install keyboard"
    • Verify that the Readme is shown in the "README" tab of the install window
    • Click "Install" button
    • Verify that the Welcome page appears after installation
    • Verify the new keyboard appears in "Keyman Configuration"
  • TEST_KB_OPTIONS:
    • In "Keyman Configuration" select the "IPA (SIL)" keyboard
    • Click "Options" button
    • Verify that the Options dialog appears

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Jan 24, 2024
@bharanidharanj
Copy link

@ermshiperete @keyman-server I was not able to test this PR, since the PR build is not available after clicking the download link.

@ermshiperete
Copy link
Contributor

@bharanidharanj you don't need Teamcity to test on Linux - see https://github.com/keymanapp/keyman/wiki/How-to-test-artifacts-from-pull-requests-for-Keyman-for-Linux

@bharanidharanj
Copy link

Test Results

GROUP_FOCAL: Ubuntu 20.04 Focal with Gnome Shell and X11

  • TEST_KB_INSTALL (PASSED): Tested this as per the instructions in Ubuntu 20.04 Focal with Gnome Shell and X11 and here is my observation: 1. Downloaded then installed the PR build (Keyman 17.0.251-alpha-local (package version 17.0.251-1~PR-10483-2137.1+focal1) from Debian Packaging Artifacts Site. 2. Downloaded and installed the "IPA (SIL) keyboard 2. Verified that the Readme was shown in the "README" tab of the install window during the installation. 3. Verified that the Welcome page appeared after the installation. 4. Verified that the "Keyman Configuration" appeared on the screen.

..Readme tab

..Welcome Page

..Keyman Configuration

  • TEST_KB_OPTIONS (PASSED): 1. Verified that the Options dialog appeared after clicking the "Options" button from Keyman Configuration window.

..Options page

GROUP_MANTIC_X11: Ubuntu 23.10 Mantic with Gnome Shell and X11

  • TEST_KB_INSTALL (PASSED): Tested this as per the instructions in Ubuntu 23.10 Manitc with Gnome Shell and X11 and here is my observation: 1. Downloaded then installed the PR build (Keyman 17.0.251-alpha-local (package version 17.0.251-1~PR-10483-2137.1+mantic1) from Debian Packaging Artifacts Site. 2. Downloaded and installed the "IPA (SIL) keyboard 2. Verified that the Readme was shown in the "README" tab of the install window during the installation. 3. Verified that the Welcome page appeared after the installation. 4. Verified that the "Keyman Configuration" appeared on the screen.

  • TEST_KB_OPTIONS (PASSED): 1. Verified that the Options dialog appeared after clicking the "Options" button from Keyman Configuration window.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 29, 2024
@ermshiperete ermshiperete merged commit eeb03e1 into keymanapp:master Jan 29, 2024
6 of 7 checks passed
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.255-alpha

ermshiperete pushed a commit that referenced this pull request Jan 31, 2024
@jbicha @ermshiperete
chore(linux): Build with webkitgtk 4.1 instead of 4.0
1d445ad 
Cherry-pick of PR #10483.
@ermshiperete ermshiperete mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

Assignees
No one assigned
Labels
has-user-test linux/
Milestone
A17S31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbicha @keyman-server @mcdurdin @ermshiperete @bharanidharanj