fix(web): touch-layout fontsize property use ⛲ #10504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Test Artifacts
|
jahorton
changed the title
jahorton
commented
Jan 25, 2024
| let gs = this.kbdDiv.style; | ||
| let bs = b.style; |
There was a problem hiding this comment.
The choice of variable names here wasn't particularly helpful.
We want to leave the layer-group font-size alone here - that's where the touch-layout fontsize property is applied, and why it was being overwritten.
mcdurdin
approved these changes
Jan 25, 2024
ermshiperete
approved these changes
Jan 25, 2024
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 17.0.253-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10444 for standard use cases. To reach "all use cases" will take a bit more work.
User Testing
TEST_BALOCHI_PHONETIC: Using the Keyman app on an iPhone - preferably on an iPhone SE (emulated or real) - verify that key caps are sufficiently large.
balochi_phonetickeyboard.balochi_phonetickeyboard.گکےتExample of the keyboard properly rendered:
How it looks on the current
master, for comparison:It may be wise to run the test a second time, with the latest
alphabuild, for comparison.(This keyboard's touch-layout requests a font-size boost of +40%.)