You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the transform generated by a key event results in no changes to the text, this will no longer trigger a change event in the apps. This means that layer switch keys will no longer erase the selection.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
GROUP_ANDROID: Run these tests in Keyman for Android
TEST_BASIC_INPUT: Verify that basic input continues to function correctly.
TEST_BACKSPACE: Type some text, then verify that backspace continues to work as normal.
TEST_CONTEXT_SYNC: Using Khmer Angkor keyboard, type ខេ. Select the numeric/symbol layer, and return to the default layer. Press ្ម (longpress on ម). Press Backspace and verify that the output on screen is ខ្ម (and not ខេ).
TEST_SELECTION_DELETION: Type two words, select the second word, and press backspace on the touch keyboard to delete it. Verify that the word is deleted as expected.
TEST_SELECTION_REPLACEMENT: Type two words, select the second word, and press a letter on the touch keybaord to replace it. Verify that the word is deleted as expected, and the new letter is left in its place.
TEST_SELECTION_LAYER_SWITCH: Type two words, select the second word, and press any layer switch key on the touch keyboard. The active layer should change, but the text should not be modified.
Fixes#7866.
When the transform generated by a key event results in no changes to the
text, this will no longer trigger a change event in the apps. This means
that layer switch keys will no longer erase the selection.
Fix proposed by @jahorton.
✅ GROUP_IOS: Run these tests in Keyman for iPhone and iPad
6 tests PASSED
✅ TEST_BASIC_INPUT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Installed sil_ipa keyboard. 2. Verified that switching between keyboards using the globe key is working fine. 3. Longpress menu options are working as expected. 4. Shift layer and Symbol layer are working as expected. 5. Tested the same in iPad (10th generation) Simulator and it works fine.
✅ TEST_BACKSPACE (PASSED): 1. Entered some texts on the Notes app then pressing the backspace key deletes the characters one by one. Verified that the backspace key functionality is working as expected. 2. Tested the same in iPad (10th generation) Simulator and it is working fine.
✅ TEST_CONTEXT_SYNC (PASSED): Retested with the updated instructions and here is my observation: 1. Installed Khmer Angkor keyboard. Switched to a Khmer Angkor keyboard. Typed ខ េ. 2. Clicked the number / symbol layer then returned to the default layer. 3. Selected ្ from the long-press menu. 4. Pressed the Backspace key and verified that the output showed ខ្ on the Screen. (notes)
✅ TEST_SELECTION_DELETION (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Typed two words on the Notes app. 2. Selected the second word. 3. Pressed the backspace key on the OSK and verified that it deletes the selected word. 4. Tested the same on iPad (10 generation) Simulator and it is working fine.
✅ TEST_SELECTION_REPLACEMENT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Typed two words on the Notes app. 2. Selected the second word. 3. Typed a letter on the touch keyboard to replace it. Verified the selected word is deleted and new letter is left in its place. 4. Tested the same on iPad (10 generation) Simulator and it is working fine.
✅ TEST_SELECTION_LAYER_SWITCH (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Typed two words on the Notes app. 2. Selected the second word. 3. Pressed the '123' number key and layer changed to another layer. Pressed the Symbol key and the the layer changed to the Symbol layer. Verified that the selected word didn't change. 4. Tested the same on the iPad (10 generation) Simulator and it is working fine.
✅ GROUP_ANDROID: Run these tests in Keyman for Android
6 tests PASSED
✅ TEST_BASIC_INPUT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android 13 Mobile device and here is my observation: 1. Installed sil_ipa keyboard. 2. Verified that switching between keyboards using the globe key is working fine. 3. Longpress menu options are working as expected. 4. Shift layer and Symbol layer are working as expected. 5. Tested the same in iPad (10th generation) Simulator and it works fine.
✅ TEST_BACKSPACE (PASSED): 1. Entered some texts on the text input screen then pressing the backspace key, deletes the characters one by one. Verified that the backspace key functionality is working as expected.
✅ TEST_CONTEXT_SYNC (PASSED): 1. Installed Khmer Angkor keyboard. Switched to a Khmer Angkor keyboard. Typed ខ េ. 2. Clicked the number / symbol layer then returned to the default layer. 3. Selected ្ from the long-press menu. 4. Pressed the Backspace key and verified that the output showed ខ្ on the Screen. (notes)
✅ TEST_SELECTION_DELETION (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android Mobile device and here is my observation: 1. Typed two words on the text input screen. 2. Selected the second word. 3. Pressed the backspace key on the OSK and verified that it deletes the selected word.
✅ TEST_SELECTION_REPLACEMENT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android 13 mobile device and here is my observation: 1. Typed two words on the text input screen. 2. Selected the second word. 3. Typed a letter on the touch keyboard to replace it. Verified the selected word is deleted and new letter is left in its place.
✅ TEST_SELECTION_LAYER_SWITCH (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android 13 Mobile device and here is my observation: 1. Typed two words on the text input screen. 2. Selected the second word. 3. Pressed the '123' number key and layer changed to another layer. Pressed the Symbol key and the the layer changed to the Symbol layer. Verified that the selected word didn't change.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_BASIC_INPUT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Installed sil_ipa keyboard. 2. Verified that switching between keyboards using the globe key is working fine. 3. Longpress menu options are working as expected. 4. Shift layer and Symbol layer are working as expected. 5. Tested the same in iPad (10th generation) Simulator and it works fine.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_BACKSPACE (PASSED): 1. Entered some texts on the Notes app then pressing the backspace key deletes the characters one by one. Verified that the backspace key functionality is working as expected. 2. Tested the same in iPad (10th generation) Simulator and it is working fine.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_CONTEXT_SYNC (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Opened https://build.palaso.org/repository/download/Keymanweb_TestPullRequests/451458:id/src/test/manual/web/unminified.html test page in the Chrome browser. 2. Run the web_context_tests keyboard on the test page. 3. Verified that the context changes were correctly synchronized between the the app and keymanweb. 4. Tested this in iPad (10th generation) simulator, and it works fine. Did I miss any other test related to context_sync? Please let me know. Thank you.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_SELECTION_DELETION (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Typed two words on the Notes app. 2. Selected the second word. 3. Pressed the backspace key on the OSK and verified that it deletes the selected word. 4. Tested the same on iPad (10 generation) Simulator and it is working fine.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_SELECTION_REPLACEMENT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Typed two words on the Notes app. 2. Selected the second word. 3. Typed a letter on the touch keyboard to replace it. Verified the selected word is deleted and new letter is left in its place. 4. Tested the same on iPad (10 generation) Simulator and it is working fine.
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_SELECTION_LAYER_SWITCH (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Typed two words on the Notes app. 2. Selected the second word. 3. Pressed the '123' number key and layer changed to another layer. Pressed the Symbol key and the the layer changed to the Symbol layer. Verified that the selected word didn't change. 4. Tested the same on the iPad (10 generation) Simulator and it is working fine.
TEST_CONTEXT_SYNC (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Opened https://build.palaso.org/repository/download/Keymanweb_TestPullRequests/451458:id/src/test/manual/web/unminified.html test page in the Chrome browser. 2. Run the web_context_tests keyboard on the test page. 3. Verified that the context changes were correctly synchronized between the the app and keymanweb. 4. Tested this in iPad (10th generation) simulator, and it works fine. Did I miss any other test related to context_sync? Please let me know. Thank you.
My apologies, that test was very badly specified by me. I was going to rewrite it and then I missed it. I have rewritten the test, which should be run with the app -- not with KeymanWeb!
TEST_CONTEXT_SYNC (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on iPhone 13 Mobile device and here is my observation: 1. Opened https://build.palaso.org/repository/download/Keymanweb_TestPullRequests/451458:id/src/test/manual/web/unminified.html test page in the Chrome browser. 2. Run the web_context_tests keyboard on the test page. 3. Verified that the context changes were correctly synchronized between the the app and keymanweb. 4. Tested this in iPad (10th generation) simulator, and it works fine. Did I miss any other test related to context_sync? Please let me know. Thank you.
My apologies, that test was very badly specified by me. I was going to rewrite it and then I missed it. I have rewritten the test, which should be run with the app -- not with KeymanWeb!
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
TEST_CONTEXT_SYNC (PASSED): Retested with the updated instructions and here is my observation: 1. Installed Khmer Angkor keyboard. Switched to a Khmer Angkor keyboard. Typed ខ េ. 2. Clicked the number / symbol layer then returned to the default layer. 3. Selected ្ from the long-press menu. 4. Pressed the Backspace key and verified that the output showed ខ្ on the Screen.
GROUP_ANDROID: Run these tests in Keyman for Android
TEST_BASIC_INPUT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android 13 Mobile device and here is my observation: 1. Installed sil_ipa keyboard. 2. Verified that switching between keyboards using the globe key is working fine. 3. Longpress menu options are working as expected. 4. Shift layer and Symbol layer are working as expected. 5. Tested the same in iPad (10th generation) Simulator and it works fine.
TEST_BACKSPACE (PASSED): 1. Entered some texts on the text input screen then pressing the backspace key, deletes the characters one by one. Verified that the backspace key functionality is working as expected.
TEST_CONTEXT_SYNC (PASSED): 1. Installed Khmer Angkor keyboard. Switched to a Khmer Angkor keyboard. Typed ខ េ. 2. Clicked the number / symbol layer then returned to the default layer. 3. Selected ្ from the long-press menu. 4. Pressed the Backspace key and verified that the output showed ខ្ on the Screen.
TEST_SELECTION_DELETION (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android Mobile device and here is my observation: 1. Typed two words on the text input screen. 2. Selected the second word. 3. Pressed the backspace key on the OSK and verified that it deletes the selected word.
TEST_SELECTION_REPLACEMENT (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android 13 mobile device and here is my observation: 1. Typed two words on the text input screen. 2. Selected the second word. 3. Typed a letter on the touch keyboard to replace it. Verified the selected word is deleted and new letter is left in its place.
TEST_SELECTION_LAYER_SWITCH (PASSED): Tested with the attached PR build (17.0.292-beta-test-11032) on an Android 13 Mobile device and here is my observation: 1. Typed two words on the text input screen. 2. Selected the second word. 3. Pressed the '123' number key and layer changed to another layer. Pressed the Symbol key and the the layer changed to the Symbol layer. Verified that the selected word didn't change.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keymanapp-test-bot
bot
added
the
user-test-missing
Fixes #7866.
When the transform generated by a key event results in no changes to the text, this will no longer trigger a change event in the apps. This means that layer switch keys will no longer erase the selection.
Fix proposed by @jahorton.
User Testing
GROUP_IOS: Run these tests in Keyman for iPhone and iPad
GROUP_ANDROID: Run these tests in Keyman for Android
TEST_BASIC_INPUT: Verify that basic input continues to function correctly.
TEST_BACKSPACE: Type some text, then verify that backspace continues to work as normal.
TEST_CONTEXT_SYNC: Using Khmer Angkor keyboard, type ខ េ. Select the numeric/symbol layer, and return to the default layer. Press ្ម (longpress on ម). Press Backspace and verify that the output on screen is ខ្ម (and not ខេ).
TEST_SELECTION_DELETION: Type two words, select the second word, and press backspace on the touch keyboard to delete it. Verify that the word is deleted as expected.
TEST_SELECTION_REPLACEMENT: Type two words, select the second word, and press a letter on the touch keybaord to replace it. Verify that the word is deleted as expected, and the new letter is left in its place.
TEST_SELECTION_LAYER_SWITCH: Type two words, select the second word, and press any layer switch key on the touch keyboard. The active layer should change, but the text should not be modified.