Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(developer/compilers): better unit test for suggestion accessibility #11085

Conversation

jahorton
Copy link
Contributor

Per #11074 (comment), this PR allows the new unit test to directly check that all model wordlist entries are accessible.

To do so, it links in @keymanapp/models-templates for use in kmc-model unit testing.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Mar 27, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S4 milestone Mar 27, 2024
Base automatically changed from fix/developer/compilers/entry-additions-to-internal-trie-nodes to beta March 27, 2024 02:29
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jahorton jahorton merged commit 7c030e3 into beta Mar 28, 2024
4 checks passed
@jahorton jahorton deleted the feat/developer/compilers/better-suggestion-accessibility-verification branch March 28, 2024 06:48
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.297-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants