Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(developer) keyboard info compiler unit tests 3 #11255

Merged

Conversation

markcsinclair
Copy link
Contributor

@markcsinclair markcsinclair commented Apr 18, 2024

Continues earlier PR #11130

For changes in the platforms test, see discussion in #11130

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Apr 18, 2024

User Test Results

Test specification and instructions

User tests are not required

@mcdurdin mcdurdin changed the base branch from beta to master April 25, 2024 06:22
@darcywong00 darcywong00 modified the milestones: B17S6, A18S1 Apr 28, 2024
@markcsinclair
Copy link
Contributor Author

One new related packages test, some tidying up using constants, clarification of platforms test (see discussion in #11130).

Some branches not yet fully covered, but all lines covered.

Ready for review.

@markcsinclair markcsinclair marked this pull request as ready for review May 6, 2024 10:21
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markcsinclair markcsinclair merged commit 9031086 into master May 7, 2024
4 checks passed
@markcsinclair markcsinclair deleted the test/developer/keyboard-info-compiler-unit-tests-3 branch May 7, 2024 14:23
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.30-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants