chore(web): updates most @types/node dependencies, makes them consistent 🏃 #11319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
web/
common/
common/models/
common/resources/
jahorton
force-pushed
the
chore/web/chai-update
branch
from
34cdbb7
to
3989298
Compare
Also updates @types/chai, given that chai was updated. No ^5.x yet, though.
jahorton
force-pushed
the
chore/web/consistent-npm-types
branch
from
508cfae
to
01d0019
Compare
mcdurdin
approved these changes
May 13, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.36-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amother notable task I identified while working on #11300 (toward resolving #10497) is that a number of our packages have considerably out-of-date
@types/nodedependencies. The testing framework we'll likely be transitioning to includes a dependency of its own that requires a more recent version than some of the packages currently utilize... including the one installed in our monorepo root package.Re:
@types/nodeupdates: https://stackoverflow.com/a/52404327Note: I believe I did leave a few package-specific
@types/nodedependencies in place. If a package used something more recent than v18, I left it untouched in case there's something v20-specific that is relevant.Fun(?) fact:
tscloads all@types/packages in node-modules when compiling, regardless of whether or not they're actually relevant to the code being compiled. This fact was breaking builds once I started to use the upcoming test framework.@keymanapp-test-bot skip