fix(web): gesture-model initial-state, callback failure handling #11321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Apr 30, 2024
|
Changes in this pull request will be available for download in Keyman version 17.0.317-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11186.
Adds error-handling for the callbacks of gesture models passed to the gesture engine, adding stability when the models aren't properly defined. Also prevents a model with invalid initial state from evaluating any further, as that could invalidate assumptions based on said check in the path model.
The gesture engine uses configured callbacks in the specified gesture models to match the needs of the library's consumer. Should an error arise at critical points in that process, we need to ensure they don't destabilize the general core processes of the gesture engine, even if we do need to cancel the failed gesture-models.
@keymanapp-test-bot skip