Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): km_core_cp -> km_core_cu #11341

Merged
merged 10 commits into from
May 9, 2024
Merged

chore(core): km_core_cp -> km_core_cu #11341

merged 10 commits into from
May 9, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented May 2, 2024 •
edited

  • km_core_cp represents a 16 bit code unit, not a code point.

Fixes: #11033

@keymanapp-test-bot skip

@srl295
chore(core): km_core_cp -> km_core_cu
6706ae0 
- km_core_cp represents a 16 bit code unit, not a code point.

Fixes: #11033
@srl295 srl295 self-assigned this May 2, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label May 2, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 2, 2024 •
edited

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S1 milestone May 2, 2024
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label May 3, 2024
@srl295 srl295 marked this pull request as ready for review May 3, 2024 19:32
ermshiperete
ermshiperete requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense and clarifies that we're dealing with code units, not code points. Unfortunately this requires an API change, and since we're renaming an API method a API version bump.

common/include/km_types.h Outdated Show resolved Hide resolved
linux/debian/libkeymancore1.symbols Outdated Show resolved Hide resolved
@srl295 @ermshiperete
chore(core): km_core_cp -> km_core_cu
fbd1c0c 
- fix comment
- fix API version

Fixes: #11033

Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
@srl295 srl295 requested a review from ermshiperete May 6, 2024 15:04
mcdurdin
mcdurdin approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- aside from chgs that @ermshiperete requested

ermshiperete
ermshiperete reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we need to bump the API version

@srl295
chre(linux): bump libkeymancore version
5e8b4a1 
- also minor typo in docs
@srl295 srl295 requested a review from jahorton as a code owner May 7, 2024 13:55
@github-actions github-actions bot added the docs label May 7, 2024
@srl295 srl295 requested a review from ermshiperete May 7, 2024 13:57
@srl295
Copy link
Member Author

srl295 commented May 7, 2024

I still think we need to bump the API version

OK.. i think I did that now.. is it correct?

@mcdurdin
Copy link
Member

mcdurdin commented May 8, 2024

Failed Developer build:

23:58:54     copy C:\BuildAgent\work\7ac43416c45637e9\keyman\core\build\x86\Release\src\keymancore-1.dll C:\BuildAgent\work\7ac43416c45637e9\keyman\developer\bin
23:58:54   The system cannot find the file specified.

This causes a cascade of file naming issues -- need to update build scripts in Keyman Developer and dependencies in tike itself.

ermshiperete
ermshiperete approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the Linux side.

linux/debian/libkeymancore2.symbols Outdated Show resolved Hide resolved
@srl295
Copy link
Member Author

srl295 commented May 8, 2024

This causes a cascade of file naming issues -- need to update build scripts in Keyman Developer and dependencies in tike itself.

am I the first to rename this file? I suppose so since it goes from 1 to 2.

See if this update works - once it works, I'll also update the docs to make the pieces easier to find.

@srl295 srl295 merged commit 01dda69 into master May 9, 2024
17 checks passed
@srl295 srl295 deleted the chore/core/11033-points-not-units branch May 9, 2024 14:32
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.32-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

Assignees

@srl295 srl295

Labels
chore common/ core/ Keyman Core developer/compilers/ developer/ide/ developer/ docs linux/engine/ linux/ mac/ windows/engine/ windows/
Milestone
A18S1
Development

Successfully merging this pull request may close these issues.

chore(common): km_core_cp should be km_core_cu
4 participants
@srl295 @mcdurdin @keyman-server @ermshiperete