Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): inverting a selection range would crash Keyman #11345

Merged
merged 1 commit into from
May 3, 2024

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented May 3, 2024

Fixes #11344.

Compare the changes made here against some of the original code changes in #11127 - it appears that a merge conflict got incorrectly applied at some point. There was originally proper inverted-range handling, but it got overwritten with code that couldn't properly handle it.

User Testing

TEST_INVERTED_SELECTION_RANGE: Using Keyman for Android as a system keyboard, ensure that backwards selection ranges do not crash the keyboard.

  • Select text, then drag one of the end points through and past the other one.
  • If the keyboard immediately disappears, or you see an error notification, FAIL this test.

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 3, 2024

User Test Results

Test specification and instructions

  • TEST_INVERTED_SELECTION_RANGE (PASSED): I tested this issue with the attached "Keyman 17.0.319-beta-test-11345" build on an Android 14 environment: Here is my observation. 1. Installed the "keyman-17.0.319.apk" file and gave all permissions to the application. 2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard boxes on the settings page. 3. Open the Chrome browser and enter some text in the search box. 4. The keyboard did not disappear when selecting some text from right to left and left to right. 5. The keyboard appears while dragging the text selection. It works well and behaves as expected now.

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S1 milestone May 3, 2024
@mcdurdin mcdurdin changed the title fix(android): fixes inverted selection-range handling fix(android): inverting a selection range would crash Keyman May 3, 2024
@dinakaranr
Copy link

dinakaranr commented May 3, 2024

Test Results

  • TEST_INVERTED_SELECTION_RANGE (PASSED): I tested this issue with the attached "Keyman 17.0.319-beta-test-11345" build on an Android 14 environment: Here is my observation. 1. Installed the "keyman-17.0.319.apk" file and gave all permissions to the application. 2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard boxes on the settings page. 3. Open the Chrome browser and enter some text in the search box. 4. The keyboard did not disappear when selecting some text from right to left and left to right. 5. The keyboard appears while dragging the text selection. It works well and behaves as expected now.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label May 3, 2024
@mcdurdin mcdurdin merged commit 28144af into beta May 3, 2024
6 checks passed
@mcdurdin mcdurdin deleted the fix/android/inverted-sel-range branch May 3, 2024 23:14
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.319-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants