fix(web): support SVG elements when checking className #11365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11364. Instead of using `className` which may be of type `SVGAnimatedString` if the element is an SVG element, use `getAttribute('class')`. As that function can return `null` if the class attribute is not defined, use optional chaining to avoid a new error... Uses the same pattern in hardwareEventKeyboard.ts, although I suspect the problem may never arise there. I audited the uses of className in our KeymanWeb source and found only these three instances which may be problematic. I have not searched elsewhere.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
approved these changes
May 6, 2024
ermshiperete
approved these changes
May 6, 2024
|
Changes in this pull request will be available for download in Keyman version 17.0.320-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11364.
Instead of using
classNamewhich may be of typeSVGAnimatedStringif the element is an SVG element, usegetAttribute('class'). As that function can returnnullif the class attribute is not defined, use optional chaining to avoid a new error...Uses the same pattern in hardwareEventKeyboard.ts, although I suspect the problem may never arise there.
I audited the uses of className in our KeymanWeb source and found only these three instances which may be problematic. I have not searched elsewhere.
@keymanapp-test-bot skip