-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(common): Add minimum-versions.md
#11386
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
I think longer term, what we could do is this:
This would avoid us unintentionally getting the two files out of sync, allow us to track the version data easily, and avoid the complications of automatic commit etc. @ermshiperete suggested in Slack:
This sounds like a great idea, only challenge is making sure we pick up all the env vars in the .inc.sh so that the .md doesn't miss any. Thought: include a table at the bottom of the .md that lists all the env vars as parsed out from the file (or you could do a funky diff of before/after env, which I am doing for Windows build.sh right now so we could copy that). |
Replaced by #11399 |
Follows #11380 and fixes #11372
This adds a
human-readableminimum-versions.md
document which cross-references documentation and help files affected by updates tominimum-versions.inc.sh
.@keymanapp-test-bot skip