Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): "Keyboard" should be lower case in UI string for font helper tool #11392

Merged
merged 1 commit into from
May 8, 2024

Conversation

rc-swag
Copy link
Contributor

@rc-swag rc-swag commented May 8, 2024

OS font helper UI string had a capital for K it should have been lower case k.

@keymanapp-test-bot skip

OS font helper UI string had a capital for K it should have been
lower case k.
@rc-swag rc-swag self-assigned this May 8, 2024
@rc-swag rc-swag requested a review from ermshiperete as a code owner May 8, 2024 01:20
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label May 8, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 8, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S1 milestone May 8, 2024
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label May 8, 2024
@rc-swag rc-swag changed the title fix: Keyboard should be lower case in UI string fix(windows): "Keyboard" should be lower case in UI string for font helper tool May 8, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rc-swag rc-swag merged commit c88b765 into master May 8, 2024
7 checks passed
@rc-swag rc-swag deleted the fix/caps-typo-strings-xml branch May 8, 2024 05:32
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.31-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants