fix(web): fix osk touch-focus tracking #11705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #11704 Also addresses _part_ of KEYMAN-WEB-HY, but not all variants.
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions
Test Artifacts
|
keymanapp-test-bot
bot
added
has-user-test
user-test-required
ermshiperete
approved these changes
Jun 6, 2024
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
mcdurdin
reviewed
Jun 7, 2024
| @@ -13,10 +13,10 @@ export default class TouchEventPromiseMap { | |||
| } | |||
|
|
|||
| public maintainTouches(list: TouchList) { | |||
| let keys = [].concat(this.map.keys()); | |||
| let keys = Array.from(this.map.keys()); | |||
There was a problem hiding this comment.
Does #11732 have any impact on this?
There was a problem hiding this comment.
This is outside of the worker.
We keep es6-shim around on Android and use it for devices with outdated WebViews; it'll cover this case well enough.
|
Changes in this pull request will be available for download in Keyman version 18.0.51-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11704
Fixes: KEYMAN-WEB-HY. Turns out that the original variant of that issue was resolved with #11505, leaving only the current form in place. (Note: is not currently commit-tagged; I realized this later.)
The offending code attained its current form in #11462, wherein I converted this class from using a
Record<,>Object-based "map" to an actual ES6Map.Before:
Object.keys().After:
map.keys().Object.keys()actually does return an array, whilemap.keys()does not. Fortunately, this means that the bug this fixes should only occur for 18.0-alpha.User Testing
TEST_ATTEMPT_REPRO: Using Keyman for Android, attempt to reproduce #11704: