fix(developer): refactor kmcmplib compiler messages to use map #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpMsg.cpp to use map
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
Not sure why this closed when I merged PR #11378 into master |
…mcmplib-compiler-messages-to-use-map
|
Merge conflicts resolved, ready to review |
The commit message was |
ermshiperete
approved these changes
Jun 13, 2024
mcdurdin
reviewed
Jun 13, 2024
| } | ||
| } | ||
| return nullptr; | ||
| KMX_CHAR *GetCompilerErrorString(KMX_DWORD code) { |
There was a problem hiding this comment.
next step, make this return a const KMX_CHAR * ... so much const missing in kmcmplib.
mcdurdin
approved these changes
Jun 13, 2024
…mcmplib-compiler-messages-to-use-map
# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
# Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
# Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
|
@mcdurdin Do you want to have another quick look? |
ermshiperete
approved these changes
Jun 14, 2024
…mcmplib-compiler-messages-to-use-map
# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
# Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
# Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
markcsinclair
deleted the
fix/developer/refactor-kmcmplib-compiler-messages-to-use-map
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.57-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor CompMsg.cpp to use a map, which removes the need for linear searching in
GetCompilerErrorStringSupporting tests added in
gtest-compmsg-test.cppRemoved from PR #11378
@keymanapp-test-bot skip