-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(developer): refactor kmcmplib compiler messages to use map #11738
fix(developer): refactor kmcmplib compiler messages to use map #11738
Conversation
…mpMsg.cpp to use map
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Not sure why this closed when I merged PR #11378 into master |
…mcmplib-compiler-messages-to-use-map
Merge conflicts resolved, ready to review |
The commit message was |
} | ||
} | ||
return nullptr; | ||
KMX_CHAR *GetCompilerErrorString(KMX_DWORD code) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next step, make this return a const KMX_CHAR *
... so much const
missing in kmcmplib.
…mcmplib-compiler-messages-to-use-map # Keyman Conventional Commit suggestions: # # - Link to a Sentry issue with git trailer: # Fixes: _MODULE_-_ID_ # - Give credit to co-authors: # Co-authored-by: _Name_ <_email_> # - Use imperative, present tense ('attach' not 'attaches', 'attached' etc) # - Don't include a period at the end of the title # - Always include a blank line before trailers # - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
@mcdurdin Do you want to have another quick look? |
…mcmplib-compiler-messages-to-use-map # Keyman Conventional Commit suggestions: # # - Link to a Sentry issue with git trailer: # Fixes: _MODULE_-_ID_ # - Give credit to co-authors: # Co-authored-by: _Name_ <_email_> # - Use imperative, present tense ('attach' not 'attaches', 'attached' etc) # - Don't include a period at the end of the title # - Always include a blank line before trailers # - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
Changes in this pull request will be available for download in Keyman version 18.0.57-alpha |
Refactor CompMsg.cpp to use a map, which removes the need for linear searching in
GetCompilerErrorString
Supporting tests added in
gtest-compmsg-test.cpp
Removed from PR #11378
@keymanapp-test-bot skip