feat(linux): Install keyboard on Gnome #3278
Conversation
This change adds the keyboard to the Gnome input sources after installing the .kmx file, and removes it on uninstall. This implements #2728.
| return [] | ||
|
|
||
| values = [] | ||
| # a(ss) |
| # a(ss) | ||
| nChildren = variant.n_children() | ||
| for i in range(nChildren): | ||
| # (ss) |
There was a problem hiding this comment.
I don't understand this comment either :)
| kmx_file = os.path.join(packageDir, keyboard['id'] + ".kmx") | ||
| if not ignore_language and "languages" in keyboard and len(keyboard["languages"]) > 0: | ||
| logging.debug(keyboard["languages"][0]) | ||
| return "%s:%s" % (keyboard["languages"][0]['id'], kmx_file) |
There was a problem hiding this comment.
So this always returns the first language in the keyboard metadata? This seems to be an obvious area for future enhancement
There was a problem hiding this comment.
Definitely. To the user this shows up as a confusing display of the keyboard in the Gnome UI. I'll create an issue. At the moment we can't improve this unless we know the language the user searched for (cf #1456)
There was a problem hiding this comment.
We're going to improve the install workflow -- in the package install dialog, we should show a selector for each keyboard to choose from the list of languages in the package; if the default can be prepulated from the search per #1456, then that's ideal, but otherwise we still get a better answer.
| __is_gnome_shell = None | ||
|
|
||
|
|
||
| def get_keyboard_id(keyboard, packageDir, ignore_language=False): |
There was a problem hiding this comment.
Can we use a different name for this function? Rationale: keyboard_id is already a fairly heavily used term in Keyman (and equates to the basename of the keyboard file sans extension (e.g. khmer_angkor).
|
|
||
| # uninstall all kmx for all languages | ||
| for kb in keyboards: | ||
| keyboard_id = get_keyboard_id(kb, packageDir) |
There was a problem hiding this comment.
Please rename keyboard_id to something that qualifies it as a gnome_keyboard_id?
There was a problem hiding this comment.
done. Named it ibus_keyboard_id.
feat(linux): address code review comments of #3278
This change adds the keyboard to the Gnome input sources after
installing the .kmx file, and removes it on uninstall.
This implements #2728.