fix(web): Null check for calculating globe key position #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test Results
|
keymanapp-test-bot
bot
added
user-test-required
mcdurdin
approved these changes
Sep 20, 2021
|
TEST_GLOBE: PASSED No keyboard error appears before and after each rotation on both Android 5.1 and 6.0. |
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 15.0.116-alpha |
This was referenced Sep 22, 2021
|
And it seems that this may be the fix for the last user-test issues Makara had noted on my ✂️ PRs. I wish I'd noticed it earlier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5725 and Sentry issue #4292
User Testing
Load the PR build in an Android 5.1 or Android 6.0 emulator