Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): kmdecomp string overflow #5970

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 25, 2021

Picked up in development of #5963.

Replaces #5969 (wrong base)

@keymanapp-test-bot skip

Picked up in development of #5963.
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Nov 25, 2021
@mcdurdin mcdurdin added this to the A15S18 milestone Nov 25, 2021
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 25, 2021

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Nov 25, 2021
NULL
};

static_assert(_countof(StoreTokens) == TSS__MAX + 2);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires c++17

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit eb2892e into feat/web/3621-newcontext-group Nov 28, 2021
@mcdurdin mcdurdin deleted the fix/developer/kmdecomp-string-overflow-1 branch November 28, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants