Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(developer): Improve active tab visibility ✂ #6314

Merged
merged 1 commit into from Mar 2, 2022
Merged

fix(developer): Improve active tab visibility ✂ #6314

merged 1 commit into from Mar 2, 2022
+13 −11

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Mar 1, 2022 •
edited

Fixes #845.
Fixes #3224.

Makes the active tab more visible both in the horizontal file tabs, and in the vertical activity tabs by changing the background colour to Keyman Light Blue (css: #79C3DA).

image

@keymanapp-test-bot skip

@mcdurdin
fix(developer): Improve active tab visibility
e078440 
Fixes #845.
Fixes #3224.

Makes the active tab more visible both in the horizontal file tabs, and
in the vertical activity tabs by changing the background colour to
Keyman Light Blue (css: `#79C3DA`).
@mcdurdin mcdurdin added this to the B15S3 milestone Mar 1, 2022
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Mar 1, 2022 •
edited

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@mcdurdin mcdurdin marked this pull request as ready for review March 1, 2022 21:50
@mcdurdin mcdurdin requested a review from sgschantz as a code owner March 1, 2022 21:50
rc-swag
rc-swag approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how sometimes the simplest changes can make a big difference :)

lgtm

@mcdurdin mcdurdin merged commit 0876f72 into master Mar 2, 2022
@mcdurdin mcdurdin deleted the fix/developer/845-3224-tab-visibility-in-developer branch March 2, 2022 01:34
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 15.0.206-beta

@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 15.0.205-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rc-swag rc-swag rc-swag approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz

Assignees
No one assigned
Labels
developer/ fix windows/
Milestone
B15S3
3 participants
@mcdurdin @keyman-server @rc-swag