fix(developer): structure sizes for kmcomp x64 #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure how this was ever working. This just adds the specific structure sizes for x64 and verifies that the Delphi sizes are the same as the reported sizes from C++. Minor tweak to printf format args for kcframe to assist in this, sorting a compiler warning.
mcdurdin
requested review from
darcywong00,
rc-swag and
sgschantz
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
|
Changes in this pull request will be available for download in Keyman version 15.0.221-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how this was ever working.Okay, looked at history, and this was broken by #5963 (commit e24b756), of all things, which added structure size sanity checks... but neglected to remember that struct sizes may differ between 32-bit and 64-bit code.This just adds the specific structure sizes for x64 and verifies that the Delphi sizes are the same as the reported sizes from C++ (as reported by
kcframe.exe --sizeof)Minor tweak to printf format args for kcframe to assist in this, sorting a compiler warning.
@keymanapp-test-bot skip