Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android/engine): Refresh OSK when changing spacebar text #6620

Merged
merged 1 commit into from
May 16, 2022
Merged

fix(android/engine): Refresh OSK when changing spacebar text #6620

merged 1 commit into from
May 16, 2022

Conversation

darcywong00
Copy link
Contributor

Fixes #6603
This update refreshes the OSK when changing the spacebar caption text.

User Testing

Setup - Install the PR build of "Keyman for Android"

  • TEST_SPACEBAR_TEXT - Verifies the spacebar caption refreshes on user selection
  1. Launch Keyman for Android
  2. Observe the default spacebar caption on sil_euro_latin is "Language + Keyboard" (e.g. English - EuroLatin (SIL))
  3. From Keyman Settings --> Spacebar caption --> Select an option and verify the keyboard caption updates accordingly:
    • Language
    • Keyboard
    • Language + Keyboard
    • Blank

@darcywong00 darcywong00 requested a review from rc-swag as a code owner May 16, 2022 04:49
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels May 16, 2022
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 16, 2022 •
edited

User Test Results

Test specification and instructions

  • ✅ TEST_SPACEBAR_TEXT (PASSED): Tested this in Android 10.0 API 29 emulator and verified that the space bar caption refreshes on every selection.

Test Artifacts

@darcywong00 darcywong00 added this to the A16S2 milestone May 16, 2022
@darcywong00 darcywong00 linked an issue May 16, 2022 that may be closed by this pull request
bug(android): the spacebar caption doesn't get refresh until after switching to a different keyboard #6603
Closed
mcdurdin
mcdurdin approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should rename the function, but LGTM anyway.

@bharanidharanj
Copy link

  • TEST_SPACEBAR_TEXT (PASSED): Tested this in Android 10.0 API 29 emulator and verified that the space bar caption refreshes on every selection.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label May 16, 2022
@darcywong00 darcywong00 merged commit 5d70adf into beta May 16, 2022
@darcywong00 darcywong00 deleted the fix/android/engine/refresh-caption branch May 16, 2022 11:47
@darcywong00 darcywong00 mentioned this pull request May 16, 2022
Closed
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 15.0.247-beta

@MakaraSok MakaraSok mentioned this pull request May 18, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@rc-swag rc-swag Awaiting requested review from rc-swag

Assignees
No one assigned
Labels
android/engine/ android/ fix has-user-test
Milestone
A16S2
Development

Successfully merging this pull request may close these issues.

bug(android): the spacebar caption doesn't get refresh until after switching to a different keyboard
4 participants
@darcywong00 @bharanidharanj @keyman-server @mcdurdin