change(web): rotation polish - OSK reload no longer needed 🍒 #7188

darcywong00 · 2022-09-02T05:36:45Z

🍒 pick of #6787 and #6979 and fixes #7169 to stable-15.0 (16.0 master already contains the fix)

User Testing

Test environments

GROUP_IOS - any iOS device should suffice
GROUP_ANDROID - any Android device should suffice

Tests

TEST_INAPP_ROTATE_P-TO-L:
1. With Keyman not active, load it in a portrait orientation.
2. Once loaded, rotate the device to a landscape orientation.
  - The test "passes" if the OSK rotates properly.
TEST_INAPP_ROTATE_L-TO-P:
1. With Keyman not active, load it in a landscape orientation.
2. Once loaded, rotate the device to a portrait orientation.
  - The test "passes" if the OSK rotates properly.
TEST_BROWSER_ROTATE_P-TO-L:
1. Before loading the test page, have the device in a portrait orientation.
2. Load the KeymanWeb testing page "Test unminified Keymanweb".
3. Select the top text area in order to display the OSK.
4. Open the language menu, but do not change keyboards.
5. Once loaded, rotate the device to a landscape orientation.
  - The test "passes" if the OSK rotates properly.
  - The test "fails" if the OSK is not visible after rotation.
TEST_BROWSER_ROTATE_L-TO-P:
1. Before loading the test page, have the device in a landscape orientation.
2. Load the KeymanWeb testing page "Test unminified Keymanweb".
3. Select the top text area in order to display the OSK.
4. Open the language menu, but do not change keyboards.
5. Once loaded, rotate the device to a portrait orientation.
  - The test "passes" if the OSK rotates properly.
  - The test "fails" if the OSK is not visible after rotation.
TEST_ANDROID_SHIFT_AFTER_GLOBE: Verifies fix to bug(android): At start of input, pressing globe key, going back, leads to stuck shift key #7169
1. Load the PR build of Keyman for Android
2. In the Keyman app with the default sil_euro_latin keyboard, the keyboard should be at start-of-sentence
3. Verify the OSK starts in the Shift layer (note, suggestions may appear in lowercase)
4. Press the globe key, then exit the Keyboard picker menu
5. Verify the OSK is still in the Shift layer
6. Press the Shift button and verify the OSK switches to the default layer

(edit) Additional user tests from #6979

SUITE_ROTATION

Test environments

GROUP_IOS_PHONE - any modern iOS phone should suffice
GROUP_IOS_TABLET - any modern iOS tablet should suffice
GROUP_OLD_IOS - try to find an iOS 12 or iOS 13 device to test with
GROUP_ANDROID_PHONE - any modern Android phone should suffice
GROUP_ANDROID_TABLET - any modern Android tablet should suffice
GROUP_ANDROID_7 - run tests against early Android if possible (Android 7.0)

Tests

TEST_OSK_PORTRAIT_LOAD:
1. Before loading the test page, have the device in a portrait orientation.
2. Load the KeymanWeb testing page "Test unminified Keymanweb".
3. Select the top text area in order to display the OSK.
4. Report on the appearance of the OSK. Does it seem reasonably positioned and sized? No cropping issues?
TEST_OSK_LANDSCAPE_LOAD:
1. Before loading the test page, have the device in a landscape orientation.
2. Load the KeymanWeb testing page "Test unminified Keymanweb".
3. Select the top text area in order to display the OSK.
4. Report on the appearance of the OSK. Does it seem reasonably positioned and sized? No cropping issues?
TEST_BROWSER_ROTATE_P-TO-L:
1. Before loading the test page, have the device in a portrait orientation.
2. Load the KeymanWeb testing page "Test unminified Keymanweb".
3. Select the top text area in order to display the OSK.
4. Open the language menu, but do not change keyboards.
5. Once loaded, rotate the device to a landscape orientation.
  - The test "passes" if the OSK rotates properly.
  - The test "fails" if the OSK is not visible after rotation.
TEST_BROWSER_ROTATE_L-TO-P:
1. Before loading the test page, have the device in a landscape orientation.
2. Load the KeymanWeb testing page "Test unminified Keymanweb".
3. Select the top text area in order to display the OSK.
4. Open the language menu, but do not change keyboards.
5. Once loaded, rotate the device to a portrait orientation.
  - The test "passes" if the OSK rotates properly.
  - The test "fails" if the OSK is not visible after rotation.

keymanapp-test-bot · 2022-09-02T05:36:55Z

User Test Results

Test specification and instructions

✅ GROUP_IOS: - any iOS device should suffice
5 tests PASSED
- ✅ TEST_INAPP_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK rotates properly.
- ✅ TEST_INAPP_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK rotates properly.
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK rotates properly.
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 15.0 / iPhone 13 Pro Simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_ANDROID_SHIFT_AFTER_GLOBE (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and verified that the OSK switches to the default layer.
✅ GROUP_ANDROID: - any Android device should suffice
5 tests PASSED
- ✅ TEST_INAPP_ROTATE_P-TO-L (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
- ✅ TEST_INAPP_ROTATE_L-TO-P (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
- ✅ TEST_ANDROID_SHIFT_AFTER_GLOBE (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK switches to the default layer.

🟥 SUITE_ROTATION:

✅ GROUP_IOS_PHONE: - any modern iOS phone should suffice
4 tests PASSED
- ✅ TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPhone 14 Pro max simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPhone 14 Pro max simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPhone 14 Pro max simulator and the OSK rotates properly. (notes)
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPhone 14 Pro max simulator and the OSK rotates properly. (notes)
✅ GROUP_IOS_TABLET: - any modern iOS tablet should suffice
4 tests PASSED
- ✅ TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPad Pro 3 generation simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPad Pro 3 generation simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPad Pro 3 generation simulator and the OSK rotates properly. (notes)
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 16.0 / iPad Pro 3 generation simulator and the OSK rotates properly. (notes)
🟥 GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with
- ✅ TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 12.4 / iPhone 7 Simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 12.4 / iPhone 7 Simulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 12.4 / iPhone 7 Simulator and the OSK rotates properly. (notes)
- 🟥 TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested with the build off of this PR: (notes)
✅ GROUP_ANDROID_PHONE: - any modern Android phone should suffice
4 tests PASSED
- ✅ TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in my Android Mobile device Version 11.0 and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in my Android Mobile device Version 11.0 and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested with Android 12 (API 31), the keyboard is shown OK after rotating to landscape. (notes)
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in my Android Mobile device Version 11.0 and the OSK rotates properly. (notes)
✅ GROUP_ANDROID_TABLET: - any modern Android tablet should suffice
4 tests PASSED
- ✅ TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in Pixel C API 31 / Android 12.0 and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in Pixel C API 31 / Android 12.0 and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in Pixel C API 31 / Android 12.0 and verified the appearance of the OSK and it rotates properly. (notes)
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in Pixel C API 31 / Android 12.0 and verified the appearance of the OSK and it rotates properly. (notes)
✅ GROUP_ANDROID_7: - run tests against early Android if possible (Android 7.0)
4 tests PASSED
- ✅ TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues. (notes)
- ✅ TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it rotates properly. (notes)
- ✅ TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it rotates properly. (notes)

Retesting Template

@keymanapp-test-bot retest SUITE_ROTATION GROUP_OLD_IOS TEST_BROWSER_ROTATE_L-TO-P

jahorton

LGTM.

jahorton · 2022-09-06T03:19:00Z

web/source/osk/anchoredOskView.ts

@@ -59,13 +61,37 @@ namespace com.keyman.osk {
      s.position = 'fixed';
    }

-    protected postKeyboardLoad() {
-      // Initializes the size of a touch keyboard.
+    public refreshLayout(pending?: boolean): void {


The main difference is that I see we didn't 🍒 the @override annotation; this is reflected by three less added lines in the lines-changed count.

There's also a dropped newline at line 70 compared to the original - that's the one additional line-change difference of note. The rest seems to match.

bharanidharanj · 2022-09-06T08:46:27Z

GROUP_IOS: - any iOS device should suffice

TEST_INAPP_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK rotates properly.
TEST_INAPP_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK rotates properly.
TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK rotates properly.
TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK appears partially on the Screen.
TEST_ANDROID_SHIFT_AFTER_GLOBE (PASSED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and verified that the OSK switches to the default layer.

bharanidharanj · 2022-09-06T09:26:19Z

GROUP_ANDROID: - any Android device should suffice

TEST_INAPP_ROTATE_P-TO-L (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
TEST_INAPP_ROTATE_L-TO-P (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK rotates properly.
TEST_ANDROID_SHIFT_AFTER_GLOBE (PASSED): Tested this with the attached PR build (Keyman 15.0.270-test-7188) in my Android Mobile device Version 11.0 and verified that the OSK switches to the default layer.

mcdurdin · 2022-09-18T22:58:44Z

TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK appears partially on the Screen.

@jahorton and @darcywong00 can you review this issue?

jahorton · 2022-09-19T02:19:58Z

TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested this with the attach PR build (15.0.270-test-7188) in iOS 15.5 / iPhone 13 Pro max simulator and the OSK appears partially on the Screen.

@jahorton and @darcywong00 can you review this issue?

I am able to reproduce the test failure on my personal iPhone, though not in Chrome emulation.

For comparison, and to ensure that it isn't broken on master, I double-checked on the same device using the test build product from #7142, which includes the already-merged 16.0-alpha version of these changes. (I double-checked that aspect - that the changes are there - as well.)

This test result does not reproduce on 16.0-alpha; somehow, there's... something different that's specific to 15.0-stable. What "something"? Good question! That'll take time to investigate.

The most obvious thing to note for investigation: the 16.0-alpha version landed in 16.0.43. Since the tests were passed then, chances are that the divergence is due to a change on 16.0-alpha before that point. Such a change would (naturally) have been missed by this cherrypick since we didn't know it to be related.

jahorton · 2022-09-19T02:42:07Z

Well, that's probably related: we should probably cherry-pick the "patch PR" followup as part of this, too. See #6979.

The original version had similarly-noted test issues, but since it'd already undergone significant review at the time, I made a "patch PR" that could be reviewed separately, in case reviewers didn't like the "patch" changes. It was fine and got included, but there's something noteworthy about how it got merged:

jahorton

Oh, right. Noting my prior comment, I'm requesting that the changes from #6979 be included in this 🍒-pick, as that should address the failed unit test.

…/6787-rotation-polish

Cherry-pick of #6979 to stable-15.0

bharanidharanj · 2022-09-20T14:40:07Z

SUITE_ROTATION:

GROUP_ANDROID_7: - run tests against early Android if possible (Android 7.0)

TEST_OSK_PORTRAIT_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues.

TEST_OSK_LANDSCAPE_LOAD (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it seems to be reasonably positioned and sized. No cropping issues.
TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it rotates properly.
TEST_BROWSER_ROTATE_L-TO-P (PASSED): Tested this with the attach PR build (15.0.271-test-7188) in API 24 / Android 7.0 emulator and verified the appearance of the OSK and it rotates properly.

bharanidharanj · 2022-09-20T15:13:21Z

@bharanidharanj TEST_BROWSER_ROTATE_L-TO-P should have rotated from landscape to portrait orientation, and the screenshot looks like it's still landscape. Are you saying the OSK failed to display in the original landscape orientation?

See the screenshot from the original PR

@darcywong00 The attached Screenshot looks like it's in Portrait orientation. (from Landscape). Actually, I am confused which emulator you are asking about.

When I tested 15.0.270-test-7188 in iOS 15.5 / iPhone 13 Pro Max Simulator, after rotating the device from Landscape to Portrait, the OSK appears partially on the Screen. (Please, see my attached Screenshot) screenshot

When I tested the same (TEST_BROWSER_ROTATE_P-TO-L) in iOS 12.4 / iPhone 7 Simulator, the OSK is failed to display in the original landscape orientation. (Please, see the attached Screenshot) screenshot

Please, let me know if further clarification is needed. Thanks.

darcywong00 · 2022-09-21T03:06:24Z

@bharanidharanj
I was asking about your test result from here:

TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 12.4 / iPhone 7 Simulator and I noticed that the OSK flashes on the screen and it does not appear on the View.

Are you saying the OSK flashed and disappeared before rotating from landscape to portrait orientation?

@jahorton - is the browser OSK expected to intermittently disappear?

bharanidharanj · 2022-09-21T06:05:54Z

@bharanidharanj I was asking about your test result from here:

TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested this with the attach PR build (15.0.271-test-7188) in iOS 12.4 / iPhone 7 Simulator and I noticed that the OSK flashes on the screen and it does not appear on the View.

Are you saying the OSK flashed and disappeared before rotating from landscape to portrait orientation?

@jahorton - is the browser OSK expected to intermittently disappear?

@darcywong00 Yes, That's right.

darcywong00 · 2022-09-23T06:26:56Z

From Friday standup, @mcdurdin said we'll hold off on this PR till @jahorton can investigate the browser OSK rotation issues.

jahorton · 2022-09-27T05:47:33Z

@jahorton - is the browser OSK expected to intermittently disappear?

I'll need to revisit it to be sure, but my memory is that KMW will usually hide the OSK pre-rotation and re-display it afterward. So, this suggests that the 'redisplay' part isn't happening for whatever reason.

jahorton · 2022-09-27T06:35:27Z

While certainly not an answer to the lingering issues from user testing mentioned above, there were a few oddities noted here on one of the original PRs: #6979 (comment)

It does make me wonder if there may be a bit more to address there as well.

jahorton · 2022-09-27T06:48:39Z

Unlike before, I'm having trouble attempting to repro the user test failures. That's going to make investigation at least a bit tricky.

MakaraSok · 2022-09-28T03:57:21Z

@keymanapp-test-bot retest SUITE_ROTATION GROUP_OLD_IOS TEST_BROWSER_ROTATE_L-TO-P GROUP_ANDROID_PHONE TEST_BROWSER_ROTATE_P-TO-L

MakaraSok · 2022-09-28T03:59:24Z

Self assigned to retest and double check the failed cases

MakaraSok · 2022-09-28T04:51:45Z

Test Results

SUITE_ROTATION:

GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with

TEST_BROWSER_ROTATE_L-TO-P (FAILED): Tested with the build off of this PR:
- on iOS 12.4 iPhone Xs Max simulator. There is no way to open the language menu as the globe key is nowhere to be found.
Here is how it looks after rotate to portrait:

If this is out of the scope of this test case, please ignore the this result.

The behavior above doesn't occur in iOS 13.7 simulator though.

In iOS 16.0 simular, it doesn't occur either.

GROUP_ANDROID_PHONE: - any modern Android phone should suffice

TEST_BROWSER_ROTATE_P-TO-L (PASSED): Tested with Android 12 (API 31), the keyboard is shown OK after rotating to landscape.

jahorton · 2022-10-04T06:10:47Z

Test Results

SUITE_ROTATION:

GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with

* **TEST_BROWSER_ROTATE_L-TO-P (FAILED):** Tested with the [build off of this PR](https://build.palaso.org/repository/download/Keymanweb_TestPullRequests/339125:id/index.html):
  
  * on iOS 12.4 iPhone Xs Max simulator. There is no way to open the language menu as the globe key is nowhere to be found.
  
  <img alt="image" width="500" src="https://user-images.githubusercontent.com/28331388/192683244-910cbb16-41b6-40f6-9eab-26734beb8cfe.png">

I may need to double-check, but I think this is the same Safari issue as noted on one of the other tests previously. Older iOS devices put the nav bar at the top rather than the bottom, but the in-page side effects were the same. If the nav bar hadn't appeared, the globe key would likely be in view.

jahorton · 2022-10-04T06:24:33Z

Come to think on it... if the 'worst' user test failure we're getting is that the OSK isn't showing after a rotation... as long as it shows again when the element is reselected, that doesn't seem too bad of an issue. Also, even that is only happening intermittently at that, so far as we've seen, right?

bharanidharanj · 2022-10-06T07:00:45Z

As per Makara's suggestion I have retested this (GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with- TEST_BROWSER_ROTATE_L-TO-P )in iOS 12.4 and here is my observation:

Tested the Landscape to Portrait mode in iPhone 7 Plus Simulator and I was able to see the OSK on the Screen in the landscape mode. However, the bottom of the OSK has been cropped.
In iPhone X Simulator after clicking the text area, the globe key is not visible on the Screen.
In iPhone xs Max Simulator, after scrolling down the page I could able to see the globe key. However, scrolling up the page will hide the globe key on the screen.

globekeyprob.mov

Tested the same in iOS 16.0, the OSK is fully visible on the Screen. Seems to be working fine in the latest iOS verion.

mcdurdin · 2022-10-06T07:12:24Z

My feeling on this, is if the issue is less severe than previously, we should merge this. In particular, if this rotation issue only impacts Keyman Web on mobile, and only impacts rotation, and is easily resolved by the user by refocusing the edit control, that's a much smaller user base, with a much less severe impact, so we should merge.

Then we should open a new issue to correct the remaining rotation issues!

mcdurdin · 2022-10-16T23:58:29Z

One fail on the old version of iOS, modern iOS versions seem to work fine.

keyman-server · 2022-10-18T18:31:23Z

Changes in this pull request will be available for download in Keyman version 15.0.271

change(web): rotation polish - OSK reload no longer needed

3924403

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Sep 2, 2022

darcywong00 added this to the A16S9 milestone Sep 2, 2022

github-actions bot added web/ web/engine/ labels Sep 2, 2022

darcywong00 linked an issue Sep 2, 2022 that may be closed by this pull request

bug(android): At start of input, pressing globe key, going back, leads to stuck shift key #7169

Closed

mcdurdin modified the milestones: A16S9, A16S10 Sep 5, 2022

darcywong00 marked this pull request as ready for review September 6, 2022 02:40

darcywong00 requested review from jahorton, sgschantz and mcdurdin as code owners September 6, 2022 02:40

jahorton approved these changes Sep 6, 2022

View reviewed changes

jahorton changed the title ~~change(web): rotation polish - OSK reload no longer needed~~ change(web): rotation polish - OSK reload no longer needed 🍒 Sep 6, 2022

jahorton mentioned this pull request Sep 6, 2022

bug(android): At start of input, pressing globe key, going back, leads to stuck shift key #7169

Closed

keymanapp-test-bot bot added the user-test-failed label Sep 6, 2022

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Sep 6, 2022

mcdurdin added the cherry-pick Change already merged into another (stable) branch label Sep 12, 2022

mcdurdin modified the milestones: A16S10, A16S11 Sep 17, 2022

jahorton requested changes Sep 19, 2022

View reviewed changes

darcywong00 added 2 commits September 19, 2022 13:51

Merge remote-tracking branch 'origin/stable-15.0' into cherrypick/web…

c235e2f

…/6787-rotation-polish

change(web): updates mobile screen dimension detection code

b6d3d38

Cherry-pick of #6979 to stable-15.0

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Sep 20, 2022

darcywong00 assigned jahorton Sep 23, 2022

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Sep 28, 2022

MakaraSok self-assigned this Sep 28, 2022

keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Sep 28, 2022

mcdurdin modified the milestones: A16S11, A16S12 Oct 2, 2022

mcdurdin modified the milestones: A16S12, A16S13 Oct 16, 2022

mcdurdin merged commit f6f7371 into stable-15.0 Oct 16, 2022

mcdurdin deleted the cherrypick/web/6787-rotation-polish branch October 16, 2022 23:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change(web): rotation polish - OSK reload no longer needed 🍒 #7188

change(web): rotation polish - OSK reload no longer needed 🍒 #7188

darcywong00 commented Sep 2, 2022 •

edited

keymanapp-test-bot bot commented Sep 2, 2022 •

edited

jahorton left a comment

jahorton Sep 6, 2022 •

edited

bharanidharanj commented Sep 6, 2022

bharanidharanj commented Sep 6, 2022

mcdurdin commented Sep 18, 2022

jahorton commented Sep 19, 2022 •

edited

jahorton commented Sep 19, 2022 •

edited

jahorton left a comment

bharanidharanj commented Sep 20, 2022 •

edited

bharanidharanj commented Sep 20, 2022

darcywong00 commented Sep 21, 2022

bharanidharanj commented Sep 21, 2022

darcywong00 commented Sep 23, 2022

jahorton commented Sep 27, 2022

jahorton commented Sep 27, 2022

jahorton commented Sep 27, 2022

MakaraSok commented Sep 28, 2022

MakaraSok commented Sep 28, 2022

MakaraSok commented Sep 28, 2022 •

edited

jahorton commented Oct 4, 2022

Test Results

SUITE_ROTATION:

GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with

jahorton commented Oct 4, 2022

bharanidharanj commented Oct 6, 2022 •

edited

mcdurdin commented Oct 6, 2022

mcdurdin commented Oct 16, 2022

keyman-server commented Oct 18, 2022

change(web): rotation polish - OSK reload no longer needed 🍒 #7188

change(web): rotation polish - OSK reload no longer needed 🍒 #7188

Conversation

darcywong00 commented Sep 2, 2022 • edited

User Testing

Test environments

Tests

Test environments

Tests

keymanapp-test-bot bot commented Sep 2, 2022 • edited

User Test Results

🟥 SUITE_ROTATION:

jahorton left a comment

Choose a reason for hiding this comment

jahorton Sep 6, 2022 • edited

Choose a reason for hiding this comment

bharanidharanj commented Sep 6, 2022

GROUP_IOS: - any iOS device should suffice

bharanidharanj commented Sep 6, 2022

GROUP_ANDROID: - any Android device should suffice

mcdurdin commented Sep 18, 2022

jahorton commented Sep 19, 2022 • edited

jahorton commented Sep 19, 2022 • edited

jahorton left a comment

Choose a reason for hiding this comment

bharanidharanj commented Sep 20, 2022 • edited

SUITE_ROTATION:

GROUP_ANDROID_7: - run tests against early Android if possible (Android 7.0)

bharanidharanj commented Sep 20, 2022

darcywong00 commented Sep 21, 2022

bharanidharanj commented Sep 21, 2022

darcywong00 commented Sep 23, 2022

jahorton commented Sep 27, 2022

jahorton commented Sep 27, 2022

jahorton commented Sep 27, 2022

MakaraSok commented Sep 28, 2022

MakaraSok commented Sep 28, 2022

MakaraSok commented Sep 28, 2022 • edited

Test Results

SUITE_ROTATION:

GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with

GROUP_ANDROID_PHONE: - any modern Android phone should suffice

jahorton commented Oct 4, 2022

Test Results

SUITE_ROTATION:

GROUP_OLD_IOS: - try to find an iOS 12 or iOS 13 device to test with

jahorton commented Oct 4, 2022

bharanidharanj commented Oct 6, 2022 • edited

mcdurdin commented Oct 6, 2022

mcdurdin commented Oct 16, 2022

keyman-server commented Oct 18, 2022

darcywong00 commented Sep 2, 2022 •

edited

keymanapp-test-bot bot commented Sep 2, 2022 •

edited

jahorton Sep 6, 2022 •

edited

jahorton commented Sep 19, 2022 •

edited

jahorton commented Sep 19, 2022 •

edited

bharanidharanj commented Sep 20, 2022 •

edited

MakaraSok commented Sep 28, 2022 •

edited

bharanidharanj commented Oct 6, 2022 •

edited