Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tk_arab] Lexical model for tk-arab #222

Merged
merged 1 commit into from Sep 21, 2023
Merged

[tk_arab] Lexical model for tk-arab #222

merged 1 commit into from Sep 21, 2023

Conversation

LornaSIL
Copy link
Contributor

New lexical model. It probably needs a good check since I haven't done much with lexical models and what I knew, I've forgotten.

@DavidLRowe
Copy link
Contributor

I was a little surprised by the double comma in the .model.ts file and also by the zero frequency count for nearly 100 words at the end of the TSV file, but the model seems to compile.

I'm guessing that the words with zero frequency count will be treated as though the count were 1 (which is what happens if the count is missing entirely), but that would be good to test. For future revisions, it would probably be better to include an explicit number.

@DavidLRowe DavidLRowe merged commit 444e07f into master Sep 21, 2023
2 checks passed
@LornaSIL LornaSIL deleted the tk_arab branch September 21, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants