feat: use new build script and kmc #226
Conversation
Replaces the old build script with a cleaner version that utilizes builder.inc.sh, standardizing our build commands. Uses `kmc` to build all source models, in a single command rather than one-by-one as previously. Handles external models more simply. Awaiting merge of changes to kmc to keymanapp/keyman/master before committing updated package.json.
| # | ||
| # Build a list of all targets that we will be building, in a specific order: | ||
| # * release | ||
| # * experimental |
There was a problem hiding this comment.
Doesn't this also add to the list of external targets in build_external_targets.txt?
|
|
||
| MODELINFO_SCHEMA_JSON="$MODELROOT/tools/model_info.source.json" | ||
| MODELINFO_SCHEMA_DIST_JSON="$MODELROOT/tools/model_info.distribution.json" | ||
| . "./resources/util.inc.sh" |
There was a problem hiding this comment.
Is this still needed?
I thought die can be replaced with builder_die (external.inc.sh). And I didn't see parse_args still being called.
There was a problem hiding this comment.
ci.sh is still using a lot of the functions in util.inc.sh, so that will need separate cleanup.
|
Should ./build.sh of the repo work on Linux now? I got these warnings/errors Is it not liking the path separator |
These look like bugs in kmc-package which we recently fixed in keymanapp/keyman#10064. So we should re-test with version 17.0.219-alpha on Linux before merging this. |
|
Tested with 17.0.222-alpha and this has now been resolved, looking for a review thx |
Fixes #224.
Replaces the old build script with a cleaner version that utilizes builder.inc.sh, standardizing our build commands.
Uses
kmcto build all source models, in a single command rather than one-by-one as previously. Handles external models more simply.TODO:
Please note: this will merge into staging-17.0, in preparation for 17.0 release. Changes on the staging-17.0 branch will not be published to keyman.com, until they are merged into master when we go to release (or when we determine the updated build tools are sufficiently stable).