Add safe mode (base24) #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a major breaking change, as it modifies how
KeymaskEncodergets seeded. This change was not 100% necessary, however it makes the initialization of the Base24 encoding alphabet slightly more efficient.Hostnames and subdomains are case-insensitive, so standard keymasks cannot be used there. This PR adds a new mode ("safe mode") that avoids the use of uppercase characters, while otherwise staying true to the design principles of the standard mode.
Safe mode is triggered with a boolean switch on the constructor options. API otherwise remains the same, bearing in mind that the block length is 14 characters in safe mode, rather than the standard 12.