refactored and new sdk deploy scripts #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note, this branch has some modifications to the test files from when I was commenting on them. I assume this can be removed if needed? |
BenKurrek
requested changes
Jan 13, 2023
deploy/ft/ft-create-sdk.js
Outdated
| const { initKeypom, createDrop, getDrops } = require("keypom-js"); | ||
|
|
||
| //funder is account to sign txns, defaults to benjiman.testnet | ||
| //numKeys default is 10, deposit defalt is 10, default drop config 1 use per key and delete on empty, metadata empty, funderBalance false |
There was a problem hiding this comment.
Let's keep comment styles consistent and have a standard for how we do comments: try to have a space after each comment and start each sentence with a capital letter (unless it's a variable)
…'t changed but will check for next commit
BenKurrek
approved these changes
Jan 24, 2023
| const KEYPOM_CONTRACT = "v1.keypom.testnet" | ||
| const FUNDING_ACCOUNT_ID = "benjiman.testnet"; | ||
| const KEYPOM_CONTRACT = "v1-3.keypom.testnet" | ||
| // const FUNDING_ACCOUNT_ID = "minqi.testnet" |
There was a problem hiding this comment.
Let's remove the comments
| @@ -97,7 +110,8 @@ async function start() { | |||
| 'ft_transfer_call', | |||
| { | |||
| receiver_id: KEYPOM_CONTRACT, | |||
| amount: amountToTransfer.toString(), | |||
| // amount: (FT_DATA.amount*NUM_KEYS * DROP_CONFIG.usesPerKey).toString(), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.