Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship links are broken #2940

Closed
webteckie opened this issue May 25, 2016 · 6 comments
Closed

Relationship links are broken #2940

webteckie opened this issue May 25, 2016 · 6 comments

Comments

@webteckie
Copy link
Contributor

Expected behavior

Clicking a relationship link should navigate to the referenced relationship.

Actual behavior

In the following image notice the link to the Post Widget but then notice the requests issued to the server. It is doing a GET on the current list with the relationship definition but with the _id of the referenced item.
image

Steps to reproduce the behavior

@mxstbr mxstbr added the bug label May 25, 2016
@mxstbr
Copy link
Collaborator

mxstbr commented May 25, 2016

That's definitely a bug I introduced with the admin ui overhaul, my bad! Good catch!

@jstockwin
Copy link
Contributor

@webteckie Just tried this on the relationship field on the e2e server. Added a new relationship and choose "e2e member". Went back to the relationship list view and clicked on "e2e member" in the "field A" column and it took me to e2e member's user item view, which is what is supposed to happen.

What am I missing to recreate this?

@pravk
Copy link

pravk commented May 25, 2016

This is the same issue I faced and reported few days back.
keystonejs/keystone-demo#51

@webteckie
Copy link
Contributor Author

This is reproducible by running the following e2e test from the keystone root directory:

node test/e2e/server.js --env default --config ./test/e2e/adminUI/nightwatch.json --test test/e2e/adminUI/tests/group999FixMe/2940.js

@webteckie
Copy link
Contributor Author

Closing ... PR #2986 fixed this.

@export-mike
Copy link
Contributor

Tests updated in the nightmare testing branch: keystonejs/keystone@8bd457b#diff-4dba9b0fc99b66b3ee6eb30ea2c37f60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants