This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Proposed static app #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonswiss This is so good :) |
MadeByMike
approved these changes
Sep 11, 2019
| @@ -0,0 +1,41 @@ | |||
| (function() { | |||
| // API URL | |||
| const apiUrl = `${window.location.href}admin/api`; | |||
There was a problem hiding this comment.
This is correct only if they haven't changed the defaults. 99% wont and especially when using the 1 click deploy. It would however be possible to get the actual URL. To do this we'd have to not use the staticApp and get the URL on the server-side before rendering the page.
We should probably capture this in an issue but this is good for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fussed about the copy or styles, I just tried to make the first version of the static app work, and look decent.
It's a good start, I guess!