Flaky UI tests on Cypress

[timleslie]

There are failing tests and flaky tests on circle CI, particularly related to Cypress.

The flaky tests are currently providing negative value, as time is being wasted during review trying to work out whether the failures are valid on each branch.

This task will investigate the recent failures and disable those tests which are not currently providing positive value.

[JedWatson]

@timleslie can this be closed now that #124 has been merged?

related: @jesstelford were there other outstanding flakey behaviours you had observed?

[jesstelford]

There were others I've fixed as part of the acl-rebase branch.

I think it'll be an ongoing issue due to the way Cypress runs the tests - we need to be vigilant about not falling into the trap of thinking Cypress will hold our hands through everything.

But this issue can be closed 👍

[timleslie]

Closing as cypress has been reasonably stable recently, and whatever problems were happening when this issue was created are no longer with us.