Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make keystone.sid cookie secure in Prod mode #1595

Closed
jesstelford opened this issue Sep 9, 2019 · 1 comment
Closed

Make keystone.sid cookie secure in Prod mode #1595

jesstelford opened this issue Sep 9, 2019 · 1 comment

Comments

@jesstelford
Copy link
Contributor

We automatically set the keystone.sid cookie when performing an authenticate<List>with<Strategy>, but it's not set to secure. We should set it to secure: true when NODE_ENV === 'production'.

See: https://www.npmjs.com/package/express-session#cookiesecure
@jesstelford jesstelford mentioned this issue Sep 9, 2019
Closed
@MadeByMike MadeByMike mentioned this issue Sep 11, 2019
Merged
@MadeByMike
Copy link
Contributor

Fixed in #1612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jesstelford @MadeByMike