Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a TimeZone field type #2937

Closed
molomby opened this issue May 11, 2020 · 5 comments
Closed

Build a TimeZone field type #2937

molomby opened this issue May 11, 2020 · 5 comments

Comments

@molomby
Copy link
Member

molomby commented May 11, 2020

Presented in the Admin UI as a select field. Storing a standard time zone name, eg. Australia/Sydney.

This type would be useful for thing like...

User preferences, eg. for storing the time zone in which all dates should be rendered before presentation to the user (screenshot from Harvest):

Screenshot 2020-05-11 at 23 03 50

Storing the time zone in for specific dates or ranges, eg. for an event (screenshot from Google Calendar):

Screenshot 2020-05-11 at 23 02 55


Note: it's important this stores the standard time zone name. No an offset, not an offset nickname (like "Australian Eastern Daylight Savings Time" or "Australian Eastern Standard Time" or their abbreviations, etc).

@VinayaSathyanarayana
Copy link
Contributor

As part of UserProfile, we should collect the User Timezone and use that for

  • display
  • default timezone for 'date-time with timezone' data entry

@stale
Copy link

stale bot commented Sep 15, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Sep 15, 2020
@molomby
Copy link
Member Author

molomby commented Sep 23, 2020

This has been bumped up a bit in priority; may be worked on soon.

In terms of implementation, I imagine this would wrap the Select type with a predetermined set of options. We'd probably source data directly from the IANA database. See for eg, the current zone1970.tab file.

Option value would be the string time zone name (eg. America/Bahia_Banderas) while the label could incorporate the comment info too (eg. maybe America/Bahia_Banderas (Central Time - Bahía de Banderas)?). These options could be updated periodically when the package was republished (or maybe as part of the build process?).

@stale stale bot removed the needs-review label Sep 23, 2020
@stale
Copy link

stale bot commented Jan 23, 2021

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Jan 23, 2021
@molomby
Copy link
Member Author

molomby commented Apr 5, 2022

See also #7327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants