Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Field View prop from isReadOnly to isDisabled #3023

Conversation

gautamsi
Copy link
Member

ref #2258

It makes more sense to have Field View to use isDisabled prop rather than isReadOnly

this PR:

  • renames prop for Field Views (only) to isDisabled from isReadOnly
    • Does not change the api for public, it remains adminConfig: { isReadOnly: true }
  • fixes disable issue in wysiwyg field.
  • added test for wysiwyg field being read only.

I have not added changeset as this should be merged to #2258 for release.
updated changeset for #2258 to reflect the change.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2020

💥 No Changeset

Latest commit: 937aed6

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes changesets to release 6 packages
Name Type
@keystonejs/app-admin-ui Minor
@keystonejs/field-content Minor
@keystonejs/fields-markdown Minor
@keystonejs/fields-wysiwyg-tinymce Minor
@keystonejs/fields Minor
@keystonejs/cypress-project-access-control Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gautamsi gautamsi changed the title Rename field is read only field to is disabled in view Rename Field View prop from isReadOnly to isDisabled May 22, 2020
@gautamsi gautamsi mentioned this pull request May 22, 2020
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think this is a good change 👍

@timleslie timleslie merged commit b1f5a14 into keystonejs:master May 24, 2020
@gautamsi gautamsi deleted the rename-field-isReadOnly-field-to-isDisabled-in-view branch May 26, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants