Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing guide is out of date #8169

Open
flexdinesh opened this issue Dec 11, 2022 · 4 comments
Open

Testing guide is out of date #8169

flexdinesh opened this issue Dec 11, 2022 · 4 comments
Assignees

Comments

@flexdinesh
Copy link
Contributor

flexdinesh commented Dec 11, 2022

In #7968 we removed the exports from @keystone-6/core/testing. Testing guide still has examples of non-existing exports from @keystone-6/core/testing. Guide needs to be updated.

@sharmsa66
Copy link

sharmsa66 commented Dec 11, 2022

@flexdinesh , Thanks for your response then please let us know how one should test context API with something like Postgres, do we need to have Postgres running? it will be great if you can provide an example for testing the express app also.

@dcousens dcousens changed the title DOCS Update: Testing guide is out of date Testing guide is out of date Jan 16, 2023
@rburgst
Copy link
Contributor

rburgst commented Apr 18, 2023

Please also note #8324

@Thinkscape
Copy link

The docs still describe non-existent classes:

I think we should completely drop this section: https://keystonejs.com/docs/guides/testing#test-runner

Unsure if setupTestEnv is coming back; Otherwise we should remove this: https://keystonejs.com/docs/guides/testing#test-environment

@dcousens
Copy link
Member

dcousens commented Jun 9, 2023

@Thinkscape I don't think setupTestEnv is coming back, getContext is 99.99% of the utility without the issues.
Could you open a pull request to remove the problematic pages? 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants