Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class-up the create-keystone-app CLI output #909

Merged
merged 1 commit into from Mar 22, 2019
Merged

Class-up the create-keystone-app CLI output #909

merged 1 commit into from Mar 22, 2019

Conversation

jesstelford
Copy link
Contributor

What it looks like now

create-ks-app-improvements

With an error

Screen Shot 2019-03-23 at 12 37 31 am

What it looked like before

create-ks-app-old

With an error

Screen Shot 2019-03-23 at 12 44 33 am

gautamsi
gautamsi approved these changes Mar 22, 2019
View reviewed changes
packages/create-keystone-app/bin/cli.js

${chalk.yellow.bold(endent`
cd ${projectDir}
${hasYarn ? 'yarn' : 'npm run'} start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need npm run for start?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesstelford jesstelford merged commit 6ea0cb0 into master Mar 22, 2019
@jesstelford jesstelford deleted the cka-improvements branch March 22, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautamsi gautamsi gautamsi approved these changes

@timleslie timleslie Awaiting requested review from timleslie

@dominikwilkowski dominikwilkowski Awaiting requested review from dominikwilkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesstelford @gautamsi