Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using Mongo, yet Keystone installs a Mongo binary #2763

Closed
thekevinbrown opened this issue Apr 17, 2020 · 0 comments · Fixed by #2772
Closed

Not using Mongo, yet Keystone installs a Mongo binary #2763

thekevinbrown opened this issue Apr 17, 2020 · 0 comments · Fixed by #2772

Comments

@thekevinbrown
Copy link
Contributor

Bug report

Describe the bug

When using the latest Keystone packages, mongodb-memory-server is installed in node_modules, which then drags in a Mongo binary. This should not be the case as I'm using the Knex Adapter and Postgres.

To Reproduce

Steps to reproduce the behaviour:

  1. Set up a postgres app
  2. npm i

Expected behaviour

Mongo Binary not installed

Screenshots

> mongodb-memory-server@6.5.2 postinstall [project]/node_modules/mongodb-memory-server
> node ./postinstall.js

mongodb-memory-server: checking MongoDB binaries cache...
mongodb-memory-server: binary path is [project]/node_modules/.cache/mongodb-memory-server/mongodb-binaries/4.0.14/mongod

System information

  • OS: macOS
  • Browser (if applies) N/A

Additional context

I think this comes from test utils, when dependencies on Mongo or Knex should happen at the adapter level.

Abogical added a commit to Abogical/keystone that referenced this issue Apr 18, 2020
Abogical added a commit to Abogical/keystone that referenced this issue Apr 18, 2020
Abogical added a commit to Abogical/keystone that referenced this issue Apr 18, 2020
Abogical added a commit to Abogical/keystone that referenced this issue Apr 18, 2020
Abogical added a commit to Abogical/keystone that referenced this issue Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant