Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Testing as Part of CI #2835

Closed
VinayaSathyanarayana opened this issue Apr 26, 2020 · 5 comments
Closed

Accessibility Testing as Part of CI #2835

VinayaSathyanarayana opened this issue Apr 26, 2020 · 5 comments

Comments

@VinayaSathyanarayana
Copy link
Contributor

Feature request

We should use https://github.com/pa11y/pa11y to test KeystoneJs for accessibility testing.

While I understand that Accessibility was taken care of earlier
#83
#524

It becomes essential that the accessibility testing be part of CI

@MadeByMike
Copy link
Contributor

If we were to make this a CI tool we'd probably look for something that integrates with our cypress tests.

I'm not sure CI is the way to go here however. I think it probably need regular auditing by human reviewers.

@VinayaSathyanarayana
Copy link
Contributor Author

Continuous Integration:

  • https://github.com/pa11y/pa11y can be integrated into Cypress test chain
  • CI Tests are to help ensure that our Accessibility Support is retained while we add new functionality/code. Rapid feedback will ensure that we do not end up with technical debt

Human Review/Audit

  • Is essential and useful, but cannot be done frequently

@VinayaSathyanarayana
Copy link
Contributor Author

We could look at https://github.com/mfrachet/cypress-audit -- for this.

@MadeByMike
Copy link
Contributor

I think Lighthouse CI is the way to go it looks really good and will give us performance metrics as well as some basic a11y test. I'm weary of slowing down CI too much so any PR for this should include some measure of the impact.

@bladey
Copy link
Contributor

bladey commented Apr 8, 2021

Keystone 5 has officially moved into active maintenance mode as we push towards the next major new version Keystone Next, you can find out more information about this transition here.

In an effort to sustain the project going forward, we're cleaning up and closing old issues such as this one. If you feel this issue is still relevant for Keystone Next, please let us know.

@bladey bladey closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants