Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack can't resolve imported css files in custom pages. #2867

Closed
LiamAttClarke opened this issue Apr 30, 2020 · 2 comments
Closed

Webpack can't resolve imported css files in custom pages. #2867

LiamAttClarke opened this issue Apr 30, 2020 · 2 comments

Comments

@LiamAttClarke
Copy link
Contributor

Bug report

Describe the bug

Importing a css file in a custom page no longer works with the latest release (@keystonejs/app-admin-ui v5.12.0).

To Reproduce

  1. Create a custom page.
  2. Import a local css file.
    Example:
import './CustomPage.css';

export default () => <div className="some-class"></div>;
  1. Start Keystone and open in the browser.

Expected behaviour

The css file should be resolved by Webpack as it did in previous versions of app-admin-ui.

Screenshots

Annotation 2020-04-30 172950

System information

  • OS: Windows

Additional context

@Nikodermus Suggested this might be caused by his recent change (#2860). Perhaps this implicitly excludes local css file resolution?

@gautamsi
Copy link
Member

gautamsi commented May 1, 2020

this should be reverted and investigated on why the css from node_modules not included when there is no exclude option specified.

Nikodermus added a commit to Nikodermus/keystone that referenced this issue May 5, 2020
…ge that break CSS import

When including node_modules, app-admin-ui doesn't work for local stylesheets, see keystonejs#2860 keystonejs#2859 keystonejs#2867
@MadeByMike
Copy link
Contributor

Resolved in #2860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants