Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The window size should be the same on 1080p screens #60

Closed
KeziahMoselle opened this issue Oct 2, 2019 · 5 comments
Closed

The window size should be the same on 1080p screens #60

KeziahMoselle opened this issue Oct 2, 2019 · 5 comments
Labels
bug Something isn't working (as expected) good first issue Good for newcomers

Comments

@KeziahMoselle
Copy link
Owner

I built the app with a 2K resolution screen and it appears too big on 1080p screens
It should keep it's ratio
@KeziahMoselle KeziahMoselle added bug Something isn't working (as expected) good first issue Good for newcomers hacktoberfest labels Oct 2, 2019
@mblancodev
Copy link

Can I tackle this one?

@KeziahMoselle
Copy link
Owner Author

Yes you can !

@mblancodev
Copy link

I don't know if this is relevant:
https://github.com/electron/electron/pull/18306, https://github.com/electron/electron/pull/18306

I'm trying to find a solution but I think I'm not understanding what I'm supposed to achieve. The aspect ratio seems fine to me

Maybe you can give an example image of how wide you want the app to be displayed as is was 2K window

@KeziahMoselle
Copy link
Owner Author

Hi !
I'm sorry I don't have my laptop for now, when i'll have it i'll upload a screenshot of it

@KeziahMoselle
Copy link
Owner Author

KeziahMoselle commented Oct 16, 2019 •
edited

1080p screen :
preview

How it should be :
preview

The window on a 1080p takes too much space, the size/ratio on my main screen is how it should be displayed even on a 1080p screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working (as expected) good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KeziahMoselle @mblancodev