fix a few issues in notebooks and change the result of l1reg to a sparse vector #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgleich
reviewed
Oct 30, 2018
| for i in range(len(p)): | ||
| if p[i] != 0: | ||
| idx[it] = i | ||
| vals[it] = p[i]*1.0 / (G.ai[i+1]-G.ai[i]) if normalize else p[i] |
There was a problem hiding this comment.
Use the degree vector that's been precomputed... this will be faster and handle weights...
There was a problem hiding this comment.
@dgleich Does this mean line 121 should be changed as well? I thought we should normalize with respect to the number of edges instead of degree.
There was a problem hiding this comment.
No, Line 121 is the ACL unweighted branch, which means we don't WANT to use degrees...
Pull Request Test Coverage Report for Build 74
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.