Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection cell documenation #1080

Merged
merged 9 commits into from
Feb 5, 2020
Merged

Collection cell documenation #1080

merged 9 commits into from
Feb 5, 2020

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Feb 4, 2020

We're missing documentation of cell collection attributes.

I added some explanatory text, and some simple examples.

pending-documentation.md Outdated Show resolved Hide resolved
pending-documentation.md Show resolved Hide resolved
pending-documentation.md Outdated Show resolved Hide resolved
pending-documentation.md Show resolved Hide resolved
pending-documentation.md Outdated Show resolved Hide resolved
pending-documentation.md Show resolved Hide resolved
pending-documentation.md Outdated Show resolved Hide resolved
pending-documentation.md Outdated Show resolved Hide resolved
Copy link
Member

@traiansf traiansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@ehildenb
Copy link
Member Author

ehildenb commented Feb 4, 2020

@dwightguth this one still needs your review.

pending-documentation.md Show resolved Hide resolved
pending-documentation.md Outdated Show resolved Hide resolved
pending-documentation.md Show resolved Hide resolved
pending-documentation.md Outdated Show resolved Hide resolved
@ehildenb
Copy link
Member Author

ehildenb commented Feb 4, 2020

@dwightguth I've addressed your comments, please re-review.

@rv-jenkins rv-jenkins merged commit 7cc7208 into master Feb 5, 2020
@rv-jenkins rv-jenkins deleted the collection-cell-docs branch February 5, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants