Adding simplification attribute to non-constructor-based equalities #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
reviewed
Jan 16, 2019
| @@ -42,6 +42,7 @@ | |||
| public static final KLabel SetItem = KLabel("SetItem"); | |||
| public static final KLabel DotMap = KLabel(".Map"); | |||
| public static final KLabel List = KLabel("_List_"); | |||
| public static final KLabel DotSet = KLabel(".Map"); | |||
There was a problem hiding this comment.
BTW, the order of these constants makes little sense.
There was a problem hiding this comment.
Thanks for catching this! And abput the order, I agree, but it's not like it was very ordered before :-)
traiansf
force-pushed
the
constructor-checks
branch
2 times, most recently
from
d2585c9
to
38055a8
Compare
| @@ -0,0 +1,56 @@ | |||
| package org.kframework.compile | |||
There was a problem hiding this comment.
Some of the other files have copyright statements.
| def constructorBased(m: Module, term: K): Boolean = term match { | ||
| case kapp: KApply => immutable(kapp.klist.items).forall(constructorOnly(m)) | ||
| case t: KAs => constructorBased(m, t.pattern) | ||
| case other => true |
There was a problem hiding this comment.
Could you add a comment explaining why returning true here works?
dwightguth
requested changes
Jan 16, 2019
|
@dwightguth what is your exact suggestion here? |
|
I mean my suggestion is to write ConstructorChecks in Java. |
traiansf
force-pushed
the
constructor-checks
branch
2 times, most recently
from
0b3196b
to
7f8f117
Compare
|
@dwightguth I've rewritten it in Java. Please re-review. |
traiansf
force-pushed
the
constructor-checks
branch
2 times, most recently
from
6d252ea
to
7367e6c
Compare
dwightguth
approved these changes
Jan 18, 2019
traiansf
force-pushed
the
constructor-checks
branch
from
7367e6c
to
0614211
Compare
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
Fixes #203 --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
Fixes #203 --------- Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.