Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent and child terminology #59

Closed
andimou opened this issue Mar 15, 2023 · 5 comments
Closed

parent and child terminology #59

andimou opened this issue Mar 15, 2023 · 5 comments
Assignees
Labels
RML-core issue related to the core part of the RML vocab RML-join issues relate to joins of RML

Comments

@andimou
Copy link
Contributor

andimou commented Mar 15, 2023

R2RML specification names the rr:parent and rr:child as parent query and child query, would we keep this terminology?

Or should we skip the query part and keep them only parent and child? I have the impression when we talk we typically use these terms.

or something else? if so, what?

@pmaria
Copy link
Collaborator

pmaria commented Mar 30, 2023

I believe it's called parent column and child column right now. I think we should change this to parent expression and child expression. I think this matches well with the proposal in #53

@bjdmeest
Copy link
Member

To fully match with #53, I'd suggest to use the names rml:parentMap and rml:childMap to refer to parent expression and child expression, and maybe have rml:parent and rml:child as their reference shortcut property (so they actually refer to parent reference and child reference).

If we don't do that I assume the most simple join will be of form below, as an expression means that the object should be an ExpressionMap?

ex:po rml:joincondition [
  rml:child [
    rml:reference "foreignId"
  ] ;
  rml:parent [
    rml:reference "Id"
  ]
] .

@andimou
Copy link
Contributor Author

andimou commented Mar 30, 2023

If I combine #59 and #53 I would think that there is no problem if we call them ParentMap and ChildMap as long as we clarify that they inherit from the ExpressionMap and not the TermMap. Namely that would allow us to use references, templates and constants but not termtype, language and datatype which feels reasonable.

cc/ @anaigmo

@andimou andimou added RML-core issue related to the core part of the RML vocab RML-join issues relate to joins of RML labels Mar 30, 2023
@anaigmo
Copy link
Collaborator

anaigmo commented Apr 5, 2023

Oki, then summing up the proposed changes in this issue:

  • Add two subclasses of :ExpressionMap: :ParentMap and :ChildMap
  • Add two new properties: :parentMap and :childMap; adjusting :parent and :child to be the shortcuts

Then instead of:

ex:po rml:joincondition [
  rml:child [
    rml:reference "foreignId"
  ] ;
  rml:parent [
    rml:reference "Id"
  ]
] .

We would have without shortcuts:

ex:po rml:joincondition [
  rml:childMap [
    rml:reference "foreignId"
  ] ;
  rml:parentMap [
    rml:reference "Id"
  ]
] .

And with shortcuts:

ex:po rml:joincondition [
  rml:child "foreignId";
  rml:parent "Id"
] .

@DylanVanAssche
Copy link
Collaborator

This issue had a proposal and is done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RML-core issue related to the core part of the RML vocab RML-join issues relate to joins of RML
Projects
None yet
Development

No branches or pull requests

5 participants