Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Svelte-Check Errors and Warnings #36

Closed
kgar opened this issue Nov 8, 2023 · 0 comments · Fixed by #38
Closed

Resolve Svelte-Check Errors and Warnings #36

kgar opened this issue Nov 8, 2023 · 0 comments · Fixed by #38
Assignees
Labels
cleanup Code cleanup, refactoring, restructuring, etc.

Comments

@kgar
Copy link
Owner

kgar commented Nov 8, 2023

npm run check-watch produces a number of errors and warnings. Resolve these.

@kgar kgar added the cleanup Code cleanup, refactoring, restructuring, etc. label Nov 8, 2023
@kgar kgar self-assigned this Nov 8, 2023
@kgar kgar closed this as completed in #38 Nov 10, 2023
kgar added a commit that referenced this issue Nov 10, 2023
…ors (#38)

* Converted NPC health formula span for rolling into a button.

Added visibility to the movement config button when focus visible.

* Pulled context menu instantiation into Foundry Adapter.

* Added back in the missing arrow character for subclasses.

* Moved class item trait selection to Foundry adapter.

* Resolved errors on
- ItemSpellDetailsTab.svelte

* Resolved errors on
- ItemActiveEffectsTab.svelte

* Resolved errors on
- ItemAction.svelte

* Resolved svelte-check errors with
- ItemAdvancementTab.svelte

* Restored Effects drag-and-drop support.

* Resolved svelte-check errors with
- ItemProfilePicture.svelte

* Fixed error that occurs in item sheet `toggleAdvancementLock`.

* Resolved svelte-check errors with
- AcShield.svelte
- AttributeBlock.svelte
- CharacterSheetFull.svelte
- Favorites.svelte
- InitiativeBlock.svelte
- ItemFavoriteControl.svelte
- tidy5e-context-menu.ts

Removed stub types from foundry-adapter.ts.

Added ambient typings for Foundry and dnd5e globals.

* Eliminated "undefined" from effect duration ...

* Resolved svelte-check warnings/errors for
- ActorMovementRow.svelte
- CharacterSheetFull.svelte
- VehicleSheetFull.svelte

Restored dynamic break-off on ActorSheetContext to allow for untyped content.

* Resolved svelte-check errors/warnings with
- RollableBlockTitle.svelte

* Resolved svelte-check errors/warnings with
- AllowEditLock.svelte

* Resolved svelte-check errors/warnings with
- TidyDropdownList.svelte -> InlineTextDropdownList.svelte

Extended button menu to allow a button class to for applying styles to the menu opener.

Revamped renamed the TidyDropdownList to InlineTextDropdownList, which leverages the ButtonMenu under the hood.

Eliminated z-indexes where able. Tagged over locations for future evaluation. Sometimes this involved moving HTML blocks around so that they layer correctly by virtue of their location in the DOM.

* Resolved errors/warnings on
- ActorPortrait.svelte
- HitDice.svelte
- TempHp.svelte

Made a "primary" mode for the Button Menu which will utilize the primary accent color on the opener button when hovered.

* Resolved errors/warnings on
- SpellbookFooter.svelte

* Resolved svelte-check warnings/errors for all remaining files.

* Added github action for running svelte-check on pull requests to main.

* Renamed the action

* test

* Removed intentional test error. Test complete. Good job, everyone

* Eliminated a z-index in resources.

* Fixed Pact preparation issue.

* Eliminated ActorHpBar. It wasn't doing anything useful.

Removed `z-index` from Bar component. Updated all users of HpBar/Bar component to relatively position all contents that overlay the relevant Bar.

* Extracted ResourceWithBar component which can provide the necessary UI for PC, NPC, Vehicle, and Vehicle Equipment HP Bars. It is extensible for future use with non-HP resource bars, also.

* Converted XP section to show/hide based on base character context from the default sheet. This enabled reactivity.

* Added dedicated lanes for Attune and Equip controls. If they are not present, a placeholder will keep the icons lined up with other tables.

* Formalize button menu command button size parameter so that standard size is 1.5rem line-height and compact size is 1rem line-height.

Made the creature size menu compact.

* Pulled back more dynamic type declarations into global foundry-and-system types.

* Removed commented code.

* Removed more 2nd party type stubs.

Reordered vehicle context props during initialization.

* Converted more PX to REM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup, refactoring, restructuring, etc.
Projects
None yet
1 participant