[#75] Added Default Sheet Tabs configs for PCs, NPCs, and Vehicles #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Same for NPCs and vehicles. Renamed associated localization key. Added UI for selecting default tabs for PCs, NPCs, and Vehicles. Upgraded load and save for Sheet Settings to have room for additional data other than just the raw settings. Adjusted data type of the default tabs settings to be an array of strings. Made some adjustments to the application shell generic styles.
Added reset to default functionality for the default tabs configs.
…n fields. Shared that code across settings form setup and use default button handling.
Extracted `getData()` function in the settings form application. Added English localization variables for tab selection validation errors. Removed misc code comments.
…ing tab. Updated Tab Selection to use the configured default tabs when an actor flag is not present.
…'s purpose from the "Default Sheet Tabs" verbiage. Extracted Reset logic to the sheet to keep the scripting in the settings components to a minimum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75