-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet more cleanup (Sourcery refactored) #33
Conversation
return "<AttrDict " + dict.__repr__(self) + ">" | ||
return f"<AttrDict {dict.__repr__(self)}>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AttrDict.__repr__
refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation
)
try: | ||
with contextlib.suppress(Exception): | ||
obj.close() | ||
except Exception: # pragma: no cover | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function _safe_close
refactored with the following changes:
- Use
contextlib
'ssuppress
method to silence an error (use-contextlib-suppress
)
This removes the following comments ( why? ):
# pragma: no cover
return dict((row[key], row) for row in resultset) | ||
return {row[key]: row for row in resultset} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function to_dict
refactored with the following changes:
- Replace list(), dict() or set() with comprehension (
collection-builtin-to-comprehension
)
"Param style '%s' does not support sequence type '%s'" | ||
% (param_style, seq.__class__.__name__) | ||
f"Param style '{param_style}' does not support sequence type '{seq.__class__.__name__}'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function make_placeholders
refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
)
try: | ||
with contextlib.suppress(Exception): | ||
dbkit.context() | ||
self.fail("Should not have been able to access context.") | ||
except Exception: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function TestBasics.test_context
refactored with the following changes:
- Use
contextlib
'ssuppress
method to silence an error (use-contextlib-suppress
)
Pull Request #32 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
more-cleanup
branch, then run:Help us improve this pull request!