issue#10: Added preview to posts on FeedViewController

[RJ-Clegg]

Issue #10

Changes made:

• Added a new extension: String+Extension.swift with a function called strippedHtml

This was needed as I noticed the API brings back a lot of HTML in some texts that we display.

• Reconfigured ListingTableViewCell to have an UIImage / Body text and title text. Using UIStackView makes showing and hiding the different UI elements trivial (Just hide views you don't want to show and that's it!) and cleans up the code in FeedViewController - no longer do we need to have logic in the UITableViewDataSource method cellForRowAt to decide which UITableViewCell we should be using.

Another advantage was not having to use optional casting, to call a method that the UITableViewCell implements - eg via the following protocol: ListingDisplayable

So at the call site this:
(cell as? ListingDisplayable)?.display(listing: listing)

becomes this:
cell.display(listing)

Furthermore, if we should need to add more UI elements to our ListingTableViewCell it will be trivial and scale easy enough, using UIStackView.

• Added a static var to the ListingTableViewCell for the reuseIdentifier - this allows us to avoid using 'string-api' which is very error prone. We get compile time safety this way.

• Removed the ListingThumbnailTableViewCell as it became redundant.

• Made a small change to ListingDisplayable protocol - I felt that at the call site: cell.display(listing) was better than cell.display(listing: listing)

• Made the @IBOutlet's private in ListingTableViewCell - no need to expose them, if we don't have to

Edit

Urgh, sorry for the extra commits; bunch of extra stuff I noticed after the original commit. No more commits now.

[kgellci]

nit, since it returns a new string, should be called strippingHTML

[RJ-Clegg]

Generally, functions aren't named by what they're doing, more towards their post-actions or action-to-be-done.

An example of this is in the Swift Standard library - for Float and Double - which have two functions; round() and rounded()

Using the above example, I feel stripHtml is just as appropriate as strippedHtml however I don't feel strippingHtml is the right choice here.

I agree though, it should have a different name, since it returns a new string - if we follow the Standard library example, strippedHtml would seem more appropriate to me.

I'll make this change before merging.

I am however open to discussing this more though, off this PR. Maybe I am missing something more obvious.

[kgellci]

Either one sounds good

[kgellci]

In a later PR, we can create ViewModels which already hold the preprocessed data.

[RJ-Clegg]

100% agree with this. I generally use the MVVM pattern with my projects. I'll create an issue for this and solve it in a upcoming PR

[kgellci]

Left a few small comments but looks good to merge.