Add CoreAPI tests

[squarefrog]

Here are some tests for CoreAPI. This tests the current behaviour, but I'd like to see this expanded in the future, as I'll mention below:

Notes

• I had to modify the getData(forRoute:parameters:completion) method to accept a mocked session. This doesn't affect the call site, thanks to default values.

• CoreAPI currently just returns CoreAPIError.random if there is no data. I feel this would be better returning the actual error returned by the URLSession.dataTask.

• Additionally, there may be some merit in using the status code from the URL response to check its in the 200-299 range.

• I modified the Makefile to accept an array of test schemes, then look through them to run the tests.

[kgellci]

Some lint issues, can run make lint to catch

[squarefrog]

Thats fine. I'd be inclined to ignore force_cast in tests though. I think safely unwrapping adds little benefit in a test. Normally, I'd override the .swiftlint.yml in the tests folder, but this will result in a lot of duplication across all the test targets. I suppose this can be tackled later.

On a side note, perhaps it would be prudent to setup Danger to catch things like lint issues?

[kgellci]

Feel free to add a ticket for danger. You can also disable swiftlint rules per file: https://github.com/realm/SwiftLint#disable-rules-in-code

[squarefrog]

True, perhaps I’d prefer that to wrapping the code block with disable rules.

[kgellci]

👍