Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Рефакторинг конфигов #58

Open
dmitry-weirdo opened this issue Jan 13, 2021 · 0 comments
Open

Рефакторинг конфигов #58

dmitry-weirdo opened this issue Jan 13, 2021 · 0 comments

Comments

@dmitry-weirdo
Copy link
Collaborator

dmitry-weirdo commented Jan 13, 2021 •
edited
Loading

Задача, чтобы было где излагать мысли и под чем коммитить.

Сейчас конфиги используются в

  • PlayerDataDownloader
  • PlayerJsonParser
  • KgParserApplication
    • Тот же конфиг для импорта данных (передаётся в PlayerJsonParser)
    • ExportContext для генерации
      • фактически те же поля, только context.dataDownloadEndDate — надо заполнить уже после завершения экспорта, то есть после работы PlayerDataDownloader.
      • startDate тоже заполняется в PlayerDataDownloader, когда он начинает загрузку данных.
  • Для генерации нужен свой конфиг, который будет настраивать:
    • Какие экспортеры (aka генераторы) запускать.
    • Желательно также добавить minRacesCount по экспортерам, чтобы можно было перегружать его для каждого экспортера.

❗ ❗ ❗ Конфиги словарей можно также перенести в json-файлы, а не создавать классы, представляющие из себя эти конфиги.
Так не получится генерировать пункты верхнего меню, но можно сгенерировать страницы, а ссылки делать из списка словарей.
dmitry-weirdo added a commit that referenced this issue Jan 17, 2021
@dmitry-weirdo
refactor: #58 Repackaged statistics-related classes into one "statist…
b884689 
…ics" package. Draft of Config class added.
dmitry-weirdo added a commit that referenced this issue Jan 17, 2021
@dmitry-weirdo
feat: #58 set up Jackson to serialize LocalDateTime and be able to se…
65a92e5 
…rialize with pretty-print. Updated Jackson version to 2.12.1.
dmitry-weirdo added a commit that referenced this issue Jan 17, 2021
@dmitry-weirdo
feat: #58 change code to the new config. KgParserApplication is chang…
b28520e 
…ed, but not yet tested.

- PlayerDataDownloader and PlayerJsonParser are working.
- Old PlayerDataDownloader.Config removed.
- Added configs for previous data loads. There will be problems with LocalDateTime parsing,
should be changed and tested (timezone and timeformat problems expected).
dmitry-weirdo added a commit that referenced this issue Jan 17, 2021
@dmitry-weirdo
feat: #58 Change Config dates to OffsetDateTime to keep the timezone.…
00851ad 
… For import, time is converted to UTC. Application checked, it's working.
dmitry-weirdo added a commit that referenced this issue Jan 17, 2021
@dmitry-weirdo
doc: #58 Updated README.md according to current configurations for th…
e660f45 
…e import executable files.
dmitry-weirdo added a commit that referenced this issue Jan 17, 2021
@dmitry-weirdo
fix: #58 Added OffsetDateTime → LocalDateTime conversion for PlayerJs…
fd9f706 
…onData.importDate → PlayerEntity.importDate conversion.
dmitry-weirdo added a commit that referenced this issue Jan 20, 2021
@dmitry-weirdo
refactor: #58 Repackaged statistics-related classes into one "statist…
8766326 
…ics" package. Draft of Config class added.
dmitry-weirdo added a commit that referenced this issue Jan 20, 2021
@dmitry-weirdo
feat: #58 set up Jackson to serialize LocalDateTime and be able to se…
39e909d 
…rialize with pretty-print. Updated Jackson version to 2.12.1.
dmitry-weirdo added a commit that referenced this issue Jan 20, 2021
@dmitry-weirdo
feat: #58 change code to the new config. KgParserApplication is chang…
8d99545 
…ed, but not yet tested.

- PlayerDataDownloader and PlayerJsonParser are working.
- Old PlayerDataDownloader.Config removed.
- Added configs for previous data loads. There will be problems with LocalDateTime parsing,
should be changed and tested (timezone and timeformat problems expected).
dmitry-weirdo added a commit that referenced this issue Jan 20, 2021
@dmitry-weirdo
feat: #58 Change Config dates to OffsetDateTime to keep the timezone.…
f9a1e8d 
… For import, time is converted to UTC. Application checked, it's working.
dmitry-weirdo added a commit that referenced this issue Jan 20, 2021
@dmitry-weirdo
doc: #58 Updated README.md according to current configurations for th…
0cf8162 
…e import executable files.
dmitry-weirdo added a commit that referenced this issue Jan 25, 2021
@dmitry-weirdo
feat: #58 Created StatisticsGeneratorConfig with boolean flag to turn…
aff7014 
… each Exporter execution on/off. Script is not yet adapted.
dmitry-weirdo added a commit that referenced this issue Jan 25, 2021
@dmitry-weirdo
feat: #58 Apply StatisticsGeneratorConfig with all exporters turned o…
c8847e7 
…n in the script. Removing stats directory before the generation.
dmitry-weirdo added a commit that referenced this issue Jan 25, 2021
@dmitry-weirdo
doc: #58 Add second argument of GENERATE_STATISTICS_FROM_DATABASE to …
2ea68db 
…README.md.
dmitry-weirdo added a commit that referenced this issue Jan 25, 2021
@dmitry-weirdo
doc: #58 Garbage characters removed from README.md.
c43a8b1
dmitry-weirdo added a commit that referenced this issue Jan 25, 2021
@dmitry-weirdo
doc: #58 README.md cleanup.
2025da5
dmitry-weirdo added a commit that referenced this issue Jan 25, 2021
@dmitry-weirdo
Merge pull request #63 from kghackers/feat/#58_refactor-configs
ed197c3 
Feat/#58 refactor configs
@dmitry-weirdo dmitry-weirdo reopened this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitry-weirdo