Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom float #261

Merged
merged 3 commits into from
May 23, 2023
Merged

Custom float #261

merged 3 commits into from
May 23, 2023

Conversation

samyycX
Copy link
Contributor

@samyycX samyycX commented Jan 19, 2023

Add an option in float menu to custom the float, i have tested it
Still need translation for other languages.

@crashzk
Copy link
Contributor

crashzk commented Feb 7, 2023

I believe that with this PR we can close issues #243 after it is merged.

@crashzk
Copy link
Contributor

crashzk commented Feb 11, 2023

@samyycX any command to use custom float? Menu has no option.

20230211141908_1

@samyycX
Copy link
Contributor Author

samyycX commented Feb 11, 2023

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

@crashzk
Copy link
Contributor

crashzk commented Feb 11, 2023

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

Exactly, I found it there, but another problem appeared now.

When I type a flooat it only shows the error message: Invalid float (0-1).

@samyycX
Copy link
Contributor Author

samyycX commented Feb 11, 2023

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

Exactly, I found it there, but another problem appeared now.

When I type a flooat it only shows the error message: Invalid float (0-1).

What did you input? try a format like 0.01

@crashzk
Copy link
Contributor

crashzk commented Feb 11, 2023

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

Exactly, I found it there, but another problem appeared now.
When I type a flooat it only shows the error message: Invalid float (0-1).

What did you input? try a format like 0.01

It worked, it has to be a number that starts with 0. the same, anything else gives an error.

I believe that now it would be interesting to just move it to the main menu and in addition to the option for the user to choose the float a menu to increase and decrease automatically, something like the wear and tear already has.

@samyycX
Copy link
Contributor Author

samyycX commented Feb 11, 2023

umm im not a native English speaker so I’m not very sure whats the purpose to move it to the main menu and what does “increase float automatically” mean.. could you explain that?

@crashzk
Copy link
Contributor

crashzk commented Feb 11, 2023

Main menu would be this what I wanted to say would be this: (Float option in this menu in case)
20230211151236_1

Then when the player clicks on the option Float from the menu inside it would be the options:

  • Increase in 0.01
  • Dominate in 0.01
  • Insert a custom float

Something similar to the weapon wear menu. (Increase %5 and Decrease %5)
20230211151613_1

@crashzk
Copy link
Contributor

crashzk commented Feb 11, 2023

@samyycX wait, I think I'm crazy, I'm confusing this Custom Float function... lol

I thought one thing and it's another... sorry.

Turned on the light here in the head, float is weapon wear too. Sorry again.

@samyycX
Copy link
Contributor Author

samyycX commented May 23, 2023

@crashzk Can this PR be merged now? if we still need to improve it please tell me

@crashzk
Copy link
Contributor

crashzk commented May 23, 2023

@crashzk Can this PR be merged now? if we still need to improve it please tell me

Unfortunately only @kgns can merge the PR, only he has access. But I made a fork for the version I use, I'm using it on my servers with your modification and it's working perfectly, without errors. For me it can be merged without problems. I'll be leaving a ping on @kgns and as soon as he gets attention he checks if everything is right and merges.

@samyycX
Copy link
Contributor Author

samyycX commented May 23, 2023

@crashzk Can this PR be merged now? if we still need to improve it please tell me

Unfortunately only @kgns can merge the PR, only he has access. But I made a fork for the version I use, I'm using it on my servers with your modification and it's working perfectly, without errors. For me it can be merged without problems. I'll be leaving a ping on @kgns and as soon as he gets attention he checks if everything is right and merges.

got it, thank u very much

@kgns kgns changed the base branch from dev to master May 23, 2023 17:52
@kgns kgns merged commit 1223332 into kgns:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants