Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add inferFromPackageJson option for filling option smartly #2

Closed
wants to merge 4 commits into from

Conversation

imcuttle
Copy link

Add inferFromPackageJson option (Default: true).
We don't need to set name / license / private / homepage / desc definitely.
There are inferred from closest package.json.

@kgryte
Copy link
Owner

kgryte commented Feb 16, 2019

@imcuttle Thanks for the PR; however, I am not inclined to merge this one, unfortunately, as inferring from the nearest package.json is too Node.js specific. A higher order utility could easily wrap this package and add support for option inference. But I don't think this utility should be that higher order utility.

@kgryte kgryte closed this Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants