Move example.jpg inside manga_ocr package #58
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43
Summary
Move
assets/example.jpg
tomanga_ocr/assets/example.jpg
, so it can be distributed by setuptools.Motivation
After installing the manga-ocr-git AUR package on Arch Linux and running the binary, it crashes because it cannot find
assets/example.jpg
. The linked issue describes a similar experience.Rationale
setup.py install --root
to installmanga_ocr
to the system. Theexample.jpg
file is indeed not included.assets/example.jpg
is included inMANIFEST.in
, but setuptools ignores it, because theassets/
directory is not inside anypackage
configured insetup.py
.assets/
under project root, but haven't found any good solution: The only option I am aware of would be:package_data={ 'manga_ocr': ['../assets/example.jpg'] }
. The problem with that is it distributes theassets/
dir right intosite-packages/
root, and not under the package namespace.example.jpg
isn't used anywhere else in the project, so hopefully moving it undermanga_ocr/
should be fine.